Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py depends on numpy #4

Closed
fredrik-johansson opened this issue Dec 4, 2018 · 2 comments
Closed

setup.py depends on numpy #4

fredrik-johansson opened this issue Dec 4, 2018 · 2 comments

Comments

@fredrik-johansson
Copy link
Collaborator

Not a big problem in practice, but there should be a cleaner way to set the paths.

@mazar
Copy link

mazar commented Apr 6, 2022

Why not have minimum needed code included in the setup.py, so there won't be a need to reference numpy? (something like this)

If it is absolutely necessary to reference numpy, maybe we should add pyproject.toml per PEP-518:

[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel", "cython", "numpy"]  # PEP 508 specifications.

@oscarbenjamin
Copy link
Collaborator

The setup.py no longer users numpy for Python >= 3.12 and uses setuptools instead. When older Python versions are no longer supported numpy will not be needed any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants