Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query arguments no longer supported #219

Open
raccettura opened this issue Jun 11, 2023 · 7 comments
Open

Query arguments no longer supported #219

raccettura opened this issue Jun 11, 2023 · 7 comments

Comments

@raccettura
Copy link

Seems like in a somewhat recent version query arguments notably (?banner=hide&sidebar=hide) no longer work.

Quickly tracing this I found:

applyUrlQueryStrings in script.js does fire, however something in resetMap() seems to cause it break and thus it never gets beyond that point.... didn't get any deeper than that.

@eric1tran
Copy link

Working OK here. What's the full url you're using? Do you have console log output?

@raccettura
Copy link
Author

Using:

/skyaware/?banner=hide&sidebar=hide

Which has been the case for maybe a year with no issue. Most of the console is boring minus maybe:
/skyaware/data-978/receiver.json?_=1686599433516 404
skyaware/upintheair.json 404
and
image

@mutability
Copy link

At a glance this is probably due to a missing receiver location.
(It shouldn't break in that case, which is a bug, but that is possibly what changed in your setup)

@raccettura
Copy link
Author

I've never had a 978mhz antenna, so no change in my setup in a long time.

@mutability
Copy link

Okay. Do you get a receiver location dot and range circles when you load the page without a query string?

@raccettura
Copy link
Author

Negative. But everything else functions. Only error is:

Error reading SkyAware978 receiver.json. SkyAware978 may be disabled

Which is correct/expected.

@mutability
Copy link

Okay, so as I mentioned above, the trigger for this is likely that you do not have a receiver location set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants