We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When creating a new project a yarn.lock file is added to the project folder causing rnv run to fail if yarn is not installed.
yarn.lock
rnv run
To Reproduce
Expected behavior rnv new should detect if yarn exists or not and only add the yarn.lock file if it does
rnv new
Screenshots or copy&paste
➜ ~ cd test ➜ test sudo rm -r bhtest [sudo] password for dotted: ➜ test nvm use 14 Now using node v14.19.0 (npm v8.4.1) ➜ test npm i -g rnv@latest npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies npm WARN deprecated babel-eslint@8.2.6: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates. npm WARN deprecated core-js@2.6.12: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js. changed 649 packages, and audited 650 packages in 17s 62 packages are looking for funding run `npm fund` for details 9 vulnerabilities (6 moderate, 3 high) To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. ➜ test npm ou -g Package Current Wanted Latest Location Depended by npm 8.4.1 8.5.0 8.5.0 node_modules/npm global ➜ test npm ls -g /home/dotted/.nvm/versions/node/v14.19.0/lib ├── corepack@0.10.0 ├── npm@8.4.1 └── rnv@0.35.2 ➜ test rnv new ┌──────────────────────────────────────────────────────────────────────────────┐ │ │ │ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │ │ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │ │ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │ │ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │ │ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │ │ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │ │ │ │ Version: 0.35.2 │ │ https://renative.org │ │ 🚀 Firing up!... │ │ $ rnv new │ │ Start Time: 2/14/2022, 12:01:06 PM │ │ │ └──────────────────────────────────────────────────────────────────────────────┘ [ task ] registerEngine:engine-core[1] [ task ] configureRuntimeDefaults[1] appId:null [ task ] checkAndMigrateProject[1] [ task ] loadPluginTemplates[1] [ task ] _parsePluginTemplateDependencies[1] scope:root [ task ] parseRenativeConfigs[1] [ task ] getWorkspaceDirPath[1] [ task ] checkAndBootstrapIfRequired[1] [ task ] loadIntegrations[1] [ task ] loadEngines[1] [ task ] findSuitableTask[1] [ info ] Current Engine: engine-core path: undefined [ task ] registerMissingPlatformEngines[1] [ task ] initializeTask[1] new [ task ] => [new] [ task ] [new] taskRnvNew[1] ? What's your project Name? (no spaces, folder based on ID will be created in this directory) bhtest ? What's your project Title? Hello Renative ? What's your App ID? com.mycompany.bhtest ? What's your Version? 0.1.0 ? What workspace to use? rnv [ task ] [new] loadPluginTemplates[2] [ task ] [new] _parsePluginTemplateDependencies[2] scope:root [ task ] [new] parseRenativeConfigs[2] [ task ] [new] getWorkspaceDirPath[2] ? What template to use? renative-template-blank ✔ Executing: npm view renative-template-blank versions ✔ Executing: npm dist-tag ls renative-template-blank ? What renative-template-blank version to use? 0.35.2 (HEAD: latest) [ task ] [new] checkNpxIsInstalled[1] ✔ Executing: npx yarn add renative-template-blank@0.35.2 ? What platforms would you like to use? (Press <space> to select, <a> to toggle all, <i> to invert selection, and <enter> to proceed) ❯◉ ios ? What platforms would you like to use? android, androidtv, web, tizen, webos, windows, chromecast ? Do you want to set-up git in your new project? Yes ? ┌──────────────────────────────────────────────────────────────────────────────┐ │ 🚀 ReNative Project Generator │ │ │ ├──────────────────────────────────────────────────────────────────────────────┤ │ │ │ Project Name (folder): bhtest │ │ Workspace: rnv │ │ Project Title: Hello Renative │ │ Project Version: 0.1.0 │ │ App ID: com.mycompany.bhtest │ │ Project Template: renative-template-blank@0.35.2 │ │ Git Enabled: true │ │ │ │ Project Platforms: │ │ android, androidtv, web, tizen, webos, windows, chromecast │ │ │ │ Project Structure: │ │ │ │ bhtest │ │ ├── appConfigs # Application flavour configuration files/assets │ │ │ └── [APP_ID] # Example application flavour │ │ │ ├── assets # Platform assets injected to ./platformAssets │ │ │ ├── builds # Platform files injected to ./platformBuilds │ │ │ ├── fonts # Folder for all custom fonts │ │ │ ├── plugins # Multi-platform plugins injections │ │ │ └── renative.json # Application flavour config │ │ ├── platformAssets # Generated cross-platform assets │ │ ├── platformBuilds # Generated platform app projects │ │ ├── src # Source code files │ │ ├── index.*.js # Entry files │ │ └── renative.json # ReNative project configuration │ │ │ └──────────────────────────────────────────────────────────────────────────────┘ Is all this correct? Yes [ task ] [new] _generateProject:renative-template-blank:0.35.2[1] [ task ] [new] checkAndCreateGitignore[1] [ info ] [new] Your .gitignore is missing. CREATING...DONE [ task ] [new] configureGit:.[1] [ info ] [new] Your project does not have a git repo. Creating one...DONE ✔ Executing: git init ✔ Executing: git add -A ✔ Executing: git commit -m "Initial" [ success ] [new] Your project is ready! navigate to project cd bhtest and run rnv run to see magic happen! [ task ] <= new $ rnv new - Done! 🚀 ┌──────────────────────────────────────────────────────────────────────────────┐ │ 🚀 SUMMARY | 2/14/2022, 12:02:23 PM │ │ $ rnv new │ ├──────────────────────────────────────────────────────────────────────────────┤ │ ReNative Version: 0.35.2 │ │ Engine: engine-core │ │ Build Scheme (-s): debug │ │ Env Info: linux | x64 | node v14.19.0 │ │ Executed Time: 0h:1m:17s:197ms │ │ │ │ [ success ] [new] Your project is ready! navigate to project cd bhtest and run rnv run to see magic happen! │ │ └──────────────────────────────────────────────────────────────────────────────┘ ➜ test cd bhtest ➜ bhtest git:(master) rnv run ┌──────────────────────────────────────────────────────────────────────────────┐ │ │ │ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │ │ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │ │ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │ │ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │ │ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │ │ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │ │ │ │ Version: 0.35.2 │ │ https://renative.org │ │ 🚀 Firing up!... │ │ $ rnv run │ │ Start Time: 2/14/2022, 12:02:36 PM │ │ │ └──────────────────────────────────────────────────────────────────────────────┘ [ task ] registerEngine:engine-core[1] [ task ] configureRuntimeDefaults[1] appId:null [ task ] checkAndMigrateProject[1] [ task ] loadPluginTemplates[1] [ task ] _parsePluginTemplateDependencies[1] scope:root [ task ] parseRenativeConfigs[1] [ task ] getWorkspaceDirPath[1] [ task ] _generatePlatformTemplatePaths[1] [ task ] checkAndBootstrapIfRequired[1] [ task ] loadIntegrations[1] [ task ] loadEngines[1] [ info ] Some engines not installed in your project: > @rnv/engine-rn@0.35.2 > @rnv/engine-rn-tvos@0.35.2 > @rnv/engine-rn-next@0.35.2 > @rnv/engine-rn-web@0.35.2 > @rnv/engine-rn-electron@0.35.2 ADDING TO PACKAGE.JSON...DONE [ task ] checkAndCreateProjectPackage[1] [ info ] Your ./package.json is missing. CREATING...DONE ┌──────────────────────────────────────────────────────────────────────────────┐ │ 🚀 SUMMARY | 2/14/2022, 12:02:37 PM │ │ $ rnv run │ ├──────────────────────────────────────────────────────────────────────────────┤ │ ReNative Version: 0.35.2 │ │ Project Name ($package.name): bhtest │ │ Project Version ($package.version): 0.1.0 │ │ Workspace ($.workspaceID): rnv │ │ Build Scheme (-s): debug │ │ Env Info: linux | x64 | node v14.19.0 │ │ Executed Time: 0h:0m:0s:126ms │ │ │ │ [ error ] You have a yarn.lock file but you don't have yarn installed. Install it or delete yarn.lock Error: You have a yarn.lock file but you don't have yarn installed. Install it or delete yarn.lock at _callee5$ (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:188:84) at tryCatch (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/node_modules/regenerator-runtime/runtime.js:63:40) at Generator.invoke [as _invoke] (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/node_modules/regenerator-runtime/runtime.js:294:22) at Generator.next (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/node_modules/regenerator-runtime/runtime.js:119:21) at asyncGeneratorStep (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:10:1728) at _next (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:10:2066) at /home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:10:2231 at new Promise (<anonymous>) at /home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:10:1972 at installPackageDependencies (/home/dotted/.nvm/versions/node/v14.19.0/lib/node_modules/rnv/dist/core/systemManager/npmUtils.js:253:182) │ │ └──────────────────────────────────────────────────────────────────────────────┘ ➜ bhtest git:(master) ✗ rm yarn.lock
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
When creating a new project a
yarn.lock
file is added to the project folder causingrnv run
to fail if yarn is not installed.To Reproduce
rnv run
Expected behavior
rnv new
should detect if yarn exists or not and only add the yarn.lock file if it doesScreenshots or copy&paste
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: