Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure_operator_cost not implemented for op Cache_103 #268

Open
TonyTangYu opened this issue Apr 27, 2022 · 4 comments · May be fixed by #622
Open

measure_operator_cost not implemented for op Cache_103 #268

TonyTangYu opened this issue Apr 27, 2022 · 4 comments · May be fixed by #622
Assignees

Comments

@TonyTangYu
Copy link

I installed FlexFlow from the source code. When I test moe in examples/cpp/mixture-of-experts folder, it gave me the following error: measure_operator_cost not implemented for op Cache_103 (type 25). Please report this issue to the FlexFlow developers.

@lockshaw
Copy link
Collaborator

lockshaw commented Nov 3, 2022

@virena Can you check and see if it's still not implemented? If it's not we can discuss with Zhihao if we plan on adding support for this

@reyna-abhyankar
Copy link
Collaborator

The current implementation sets all cost_metrics fields to 0. There is a // TODO: implement at the top, so I'm guessing we do want to support something a little more than a dummy function? @lockshaw

@lockshaw
Copy link
Collaborator

lockshaw commented Nov 7, 2022

@jiazhihao What does the Cache operator do? I'm guessing it's MoE-related? I know you'd mentioned some of those operators should be deprecated, is this one of them or should @virena go and implement measure_operator_cost?

@lockshaw
Copy link
Collaborator

The Cache code has been removed in #622, so this PR will effectively be closed/rendered out-of-date by that. I'm guessing a new implementation will be added back in in #475 (@jiazhihao @gabrieleoliaro correct me if I'm wrong here)

@lockshaw lockshaw linked a pull request Jun 16, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants