You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a number of suggestions for how to improve attributions, and would be happy to contribute code.
Allow multiple attribution sources. Right now it's just kinda one with a widget builder, but the helper functions could be a lot more interesting IMO.
Make attribution collapse on small screens. This is a huge problem right now IMO. The next logical step once we have the above default builder is to allow it to collapse on small screens and pop up a list or something (need to do a bit of research the best way to do this in Flutter but I'm sure it's possible).
Option to pass a URL rather than a tap handler. This is really what 99% of people want anyways. I'm not sure if you're OK with another dependency, but url_launcher is what I use. Just making this part of the builder helpers would make things SO much cleaner. As a bonus, attribution to flutter_map would be a hyperlink rather than just text ;)
Let me know if you have any thoughts/objections, but I have already implemented most of the first and last items locally.
What other alternatives are available?
Yeah, just doing a bunch of boilerplate myself for some of them. There actually isn't a proper way to attribute multiple sources at this point correctly since you only have one tap handler (ok sure pop up a selection box but that's SUPER clunky).
Hi @ianthetechie.
I originally made the attribution system, and at the time, it was just a quick thing to replace some older APIs. It definitely needs changing.
I'll look into this, and attach a PR when it's ready.
Note that this will be breaking, so I'll have to merge into 'delayed-breaking-changes' until we're ready to release a bigger version.
What do you want implemented?
I have a number of suggestions for how to improve attributions, and would be happy to contribute code.
Let me know if you have any thoughts/objections, but I have already implemented most of the first and last items locally.
What other alternatives are available?
Yeah, just doing a bunch of boilerplate myself for some of them. There actually isn't a proper way to attribute multiple sources at this point correctly since you only have one tap handler (ok sure pop up a selection box but that's SUPER clunky).
Can you provide any other information?
No response
Platforms Affected
Android, iOS, Web, Windows, MacOS, Linux
Severity
Annoying: Currently have to use workarounds
Requirements
The text was updated successfully, but these errors were encountered: