Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect package url when using -syncer-packages-url #897

Closed
alejandro-ripoll opened this issue Jan 13, 2025 · 3 comments
Closed

Incorrect package url when using -syncer-packages-url #897

alejandro-ripoll opened this issue Jan 13, 2025 · 3 comments

Comments

@alejandro-ripoll
Copy link

alejandro-ripoll commented Jan 13, 2025

Description

After enabling -syncer-packages-url, {{ARCH}} is replaced with "amd64" instead of "amd64-usr" on packages url, causing download to fail.

Impact

Unable to download flatcar updates using -syncer-packages-url.

Environment and steps to reproduce

  1. Set-up:
    Setup a corporate proxy on https:///myrepository/raw-proxy-flatcar/ for https://update.release.flatcar-linux.net/.
    Configure Nebraska with -syncer-packages-url=https:///myrepository/raw-proxy-flatcar/{{ARCH}}/{{VERSION}}
  2. Error: ARCH is incorrectly replaced on new packages created by syncer, for example https:///myrepository/raw-proxy-flatcar/amd64/4081.2.1 instead of https:///myrepository/raw-proxy-flatcar/amd64-usr/4081.2.1.

Expected behavior

URL for packages created by syncer should be valid.

Additional information

Nebraska version: 2.9.0

Relevant code:
https://github.com/flatcar/nebraska/blob/main/backend/pkg/syncer/syncer.go#L386
https://github.com/flatcar/nebraska/blob/main/backend/pkg/syncer/syncer.go#L292

@tormath1
Copy link
Contributor

Hello @alejandro-ripoll and thanks for report. The --syncer-packages-url is actually a template URL, so if your targeted URL needs -usr, you could try to set it via this URL: -syncer-packages-url=https:///myrepository/raw-proxy-flatcar/{{ARCH}}-usr/{{VERSION}}.

Let us know if it solves your issue.

@alejandro-ripoll
Copy link
Author

Hi @tormath1, that works.
Thanks a lot for the quick response.

@ErvinRacz
Copy link
Contributor

ErvinRacz commented Jan 13, 2025

Hello @alejandro-ripoll,
Thanks for reporting the problem found by your use case. Arguably it is an important one which Nebraska missed the documentation for.

I just added a small note under the example with the -syncer-packages-url option based on your experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants