Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the mail server is down or not accessible at that moment, the register process will be damaged #1769

Closed
lubobill1990 opened this issue Apr 2, 2019 · 6 comments

Comments

@lubobill1990
Copy link
Contributor

Bug Report

Current Behavior
A clear and concise description of the behavior.

Steps to Reproduce

  1. go to the register page
  2. if mail server is down at that moment
  3. user can't register because the AccountActivationMailer doesn't catch exception when sending mail.

Expected Behavior
A

Screenshots
If applicable, add screenshots to help explain your problem.
image

Environment

  • Flarum version: latest
  • Website URL: http://example.com
  • Webserver: [e.g. apache, nginx]
  • Hosting environment: [e.g. shared, vps]
  • PHP version: 7.3
  • Browser: [e.g. chrome 67, safari 11]
@luceos
Copy link
Member

luceos commented Apr 2, 2019

What behaviour do you expect? The mail to be delayed or registration to succeed nevertheless and auto activating the user?

@franzliedke are we going to introduce queues or scheduled tasks in core?

@lubobill1990
Copy link
Contributor Author

@luceos I except to catch the exception and log the exception to notify the administrator.
I think the activation mail sending failure is not so significant to prevent the register process.
Especially in my scenario, I'm developing mobile app with flarum as the backend, email is not sufficient to register an user.

I'm looking forward to have official queue or scheduled tasks in core. Currently, I'm using a queue extension https://github.com/ZhiShiQ/FlarumQueue developed by myself based on illuminate/queue.

@tobyzerner
Copy link
Contributor

tobyzerner commented Apr 6, 2019

@franzliedke are we going to introduce queues or scheduled tasks in core?

yes #978

@stale

This comment has been minimized.

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Jan 18, 2020
@franzliedke franzliedke added this to the 0.1 milestone Jan 19, 2020
@stale stale bot removed the stale Issues that have had over 90 days of inactivity label Jan 19, 2020
@askvortsov1
Copy link
Member

Considering all the mail verification and testing features, and that #978 should essentially fix this, should we close this in favor of #978?

@lubobill1990
Copy link
Contributor Author

Yes, thanks

@franzliedke franzliedke modified the milestones: 0.1, 0.1.0-beta.13 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants