Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine binding contexts to speedup hook execution on high loads #140

Closed
diafour opened this issue Mar 11, 2020 · 1 comment
Closed

Combine binding contexts to speedup hook execution on high loads #140

diafour opened this issue Mar 11, 2020 · 1 comment
Milestone

Comments

@diafour
Copy link
Contributor

diafour commented Mar 11, 2020

  1. If queue contains a sequence of HookRun tasks for one hook, then this hook can be executed with combined binding context.
  2. Binding context is already an array, so hook should iterate over it, not just get first element.
  3. A pack of binding contexts with similar skipKey can be compacted, so only the latest binding context will remain.
@diafour diafour added this to the 1.0.0-beta.9 milestone Mar 13, 2020
@diafour
Copy link
Contributor Author

diafour commented Mar 18, 2020

1 and 2 are implemented in #144

3 is implemented in #150:
skipKey renamed to group. A pack of binding context with similar group is compacted to one binding context. This compacted context contains only "binding" and "snapshots" fields.
group and includeSnapshotsFrom keys are mutually exclusive.
If group is defined, then includeSnapshotsFrom is filled with all kubernetes bindings in this group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant