Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jq 1.6 has a poor performance #10

Closed
diafour opened this issue Mar 19, 2020 · 2 comments
Closed

jq 1.6 has a poor performance #10

diafour opened this issue Mar 19, 2020 · 2 comments

Comments

@diafour
Copy link
Contributor

diafour commented Mar 19, 2020

Related issue: jqlang/jq#2069

There was a migration to the tag "1.6" in jq sources because of crashes: #6. But 1.6 has poor performance. So the plan is:

  • create a benchmark to check if libjq-go is affected
  • choose a commit in master branch that has a good performance and don't crash on subsequent calls

Also, a 1.5 branch can be created with jq sources from tag "1.5".

@diafour
Copy link
Contributor Author

diafour commented Mar 31, 2020

Apart from the poor performance there is a problem with sequential Run calls. If jq expression has fromjson or tonumber that fail, then subsequent calls to jq_compile will fail and segfaulted.

The last commit that works well is jqlang/jq@b6be13d. Also, this commit has good performance. So stick to this one: #11

@diafour
Copy link
Contributor Author

diafour commented Jul 24, 2020

Can be closed as resolved:

  • No issues with jq performance in shell-operator since v1.0.0-beta.9 release.
  • README now contains information regarding choosing a jq commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant