Remove multiclustercidr logic from code #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all logic around multiclustercidr flag becasuse Kubernetes 1.29 has removed ClusterCIDR type completely from the networking group Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
thomasferrandiz
approved these changes
Dec 14, 2023
rbrtbnfgl
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all logic around multiclustercidr flag becasuse Kubernetes 1.29 has removed ClusterCIDR type completely from the networking group
Description
Since Kubernetes v1.29 has removed the ClusterCIDR type completely from the networking group kubernetes/kubernetes@c2d473f and the code still reference this type, we are having a problem to build k3s with the latest kubernetes 1.29 because it references flannel code.