Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks suggestions #140

Open
Shadowblitz16 opened this issue Jul 29, 2022 · 1 comment
Open

Looks suggestions #140

Shadowblitz16 opened this issue Jul 29, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Shadowblitz16
Copy link

To begin let me say I like the idea behind this library
However I've noticed that this libraries default theme very unprofessional.

I have a few suggestions how to possibly make it look a bit better.

  • Get rid the the thick rounded borders make it flat rounded and possibly in the future when (and if) you support themes allow border and rounding size for all four cardinal directions.

  • Make check boxes use check mark instead of x and try to leave some space around it and the edge of the checkbox

  • Icons and fonts should be mono space by default. This is because it makes things look better since you won't have icons of different sizes. changing fonts could be a them option

  • Scrollbar sliders should be rounded if part 1 of this suggestion is done

  • x and minus buttons on windows should not be thinker then 1 pixel unless the minus button is something like imgui's down arrow.

If this suggestion offended you I'm sorry that's not what I meant to do.
I intended to suggest improvements to the default theme to make it look more presentable to people that just look at something and judge it from first impressions.

@flamendless
Copy link
Owner

Hi there, appreciate the points you raise there. You can make a PR with your desired theme changes and we will check if that is better looking :)

You can refer to this: https://github.com/flamendless/Slab/wiki/Style

@flamendless flamendless added enhancement New feature or request good first issue Good for newcomers labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants