Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding scale and angle to devtools attributes #3267

Merged
merged 3 commits into from
Aug 12, 2024
Merged

feat: Adding scale and angle to devtools attributes #3267

merged 3 commits into from
Aug 12, 2024

Conversation

erickzanardo
Copy link
Member

Description

Adds scaling and angle to the dev tools form. Also fix a caching issue that was presenting outdated values to the user.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team August 12, 2024 00:53
luanpotter
luanpotter approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo requested a review from spydon August 12, 2024 14:40
spydon
spydon approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@erickzanardo erickzanardo enabled auto-merge (squash) August 12, 2024 14:47
@erickzanardo erickzanardo merged commit b2a5e65 into main Aug 12, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/adding-angle-scale-devtools branch August 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzanardo @spydon @luanpotter