Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Invoice Double Entry not filtering inactive/sub account AR #135

Closed
1 of 4 tasks
brandonrf94 opened this issue Jul 9, 2024 · 2 comments · Fixed by #134 or #136
Closed
1 of 4 tasks

[Bug] Invoice Double Entry not filtering inactive/sub account AR #135

brandonrf94 opened this issue Jul 9, 2024 · 2 comments · Fixed by #134 or #136
Assignees
Labels
error:unforced status:in_review Currently in review type:bug Something is broken or incorrect

Comments

@brandonrf94
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

In most places of your transforms you are selecting and filtering the AR accounts.

where account_type = '{{ var('quickbooks__accounts_receivable_reference', 'Accounts Receivable') }}'

This also needs to be done here, if someone deletes an AR account then you'll start duplicating rows.

Relevant error log or model output

No response

Expected behavior

Filter to one active AR account.

dbt Project configurations

Any

Package versions

Any

What database are you using dbt with?

snowflake

dbt Version

Any

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@brandonrf94 brandonrf94 added the type:bug Something is broken or incorrect label Jul 9, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the status:scoping Currently being scoped label Jul 11, 2024
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @brandonrf94 thanks for opening this issue!

I see what you are saying that a deleted AR account could be brought through via this logic. I do also see how we are doing this for all other models where we bring in AR accounts and we should be applying the same logic for invoices. We will need to apply the following condition for the invoice double entry model:

where account_type = '{{ var('quickbooks__accounts_receivable_reference', 'Accounts Receivable') }}'
and is_active
and not is_sub_account

This is a fairly low lift update and we can easily integrate this into the WIP branch @fivetran-avinash is currently working on within PR #134. I will coordinate with our team to integrate this update in the next upcoming release for early next week.

Thanks again @brandonrf94 for helping raise these issues across the dbt package and helping us address them 😄

@fivetran-joemarkiewicz fivetran-joemarkiewicz added status:accepted Scoped and accepted into queue error:unforced and removed status:scoping Currently being scoped labels Jul 11, 2024
@fivetran-avinash fivetran-avinash self-assigned this Jul 13, 2024
@fivetran-avinash fivetran-avinash added status:in_progress Currently being worked on and removed status:accepted Scoped and accepted into queue labels Jul 13, 2024
@fivetran-avinash fivetran-avinash added status:in_review Currently in review and removed status:in_progress Currently being worked on labels Jul 22, 2024
@fivetran-avinash fivetran-avinash linked a pull request Jul 22, 2024 that will close this issue
@fivetran-avinash
Copy link
Contributor

Hi @brandonrf94 ! Our latest release of dbt_quickbooks is live on the hub. It should have gone ahead and fixed this issue.

Please check it out and let us know if you have any issues or questions. Thanks again for your great collabration as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:unforced status:in_review Currently in review type:bug Something is broken or incorrect
Projects
None yet
3 participants