-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Invoice Double Entry not filtering inactive/sub account AR #135
Comments
Hi @brandonrf94 thanks for opening this issue! I see what you are saying that a deleted AR account could be brought through via this logic. I do also see how we are doing this for all other models where we bring in AR accounts and we should be applying the same logic for invoices. We will need to apply the following condition for the invoice double entry model: dbt_quickbooks/models/double_entry_transactions/int_quickbooks__credit_memo_double_entry.sql Lines 39 to 41 in e604697
This is a fairly low lift update and we can easily integrate this into the WIP branch @fivetran-avinash is currently working on within PR #134. I will coordinate with our team to integrate this update in the next upcoming release for early next week. Thanks again @brandonrf94 for helping raise these issues across the dbt package and helping us address them 😄 |
Hi @brandonrf94 ! Our latest release of Please check it out and let us know if you have any issues or questions. Thanks again for your great collabration as always! |
Is there an existing issue for this?
Describe the issue
In most places of your transforms you are selecting and filtering the AR accounts.
dbt_quickbooks/models/double_entry_transactions/int_quickbooks__invoice_double_entry.sql
Line 93 in e604697
This also needs to be done here, if someone deletes an AR account then you'll start duplicating rows.
Relevant error log or model output
No response
Expected behavior
Filter to one active AR account.
dbt Project configurations
Any
Package versions
Any
What database are you using dbt with?
snowflake
dbt Version
Any
Additional Context
No response
Are you willing to open a PR to help address this issue?
The text was updated successfully, but these errors were encountered: