Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/update passthrough columns #60

Conversation

kchiodo
Copy link
Contributor

@kchiodo kchiodo commented Jan 16, 2023

Are you a current Fivetran customer?
Yes, Fivetran customer from Maple

What change(s) does this PR introduce?
I adjusted the end models to properly pass through columns from the source package. Currently, the package only does this for Netsuite2
#44

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Local

Select which warehouse(s) were used to test the PR

  • Redshift

Provide an emoji that best describes your current mood
❗🧨🤓

@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p2 Affects most users; fix needed type:bug Something is broken or incorrect status:in_review Currently in review update_type:models Primary focus requires model updates labels Jan 17, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kchiodo thanks so much for taking the initiative to help our efforts and open a PR! 🎉

I was able to review your updates and have a small suggested edit within the CHANGELOG and a more open ended question within the netsuite__balance_sheet model changes as I was unable to successfully run the branch without using the proposed edit.

In addition to the small edit and addressing the question for the balance sheet model, would you be able to index the package version within the dbt_project.yml and integration_tests/dbt_project.yml to be the new 0.7.1 version following this release.

Let me know if you have any questions!

CHANGELOG.md Outdated Show resolved Hide resolved
models/netsuite/netsuite__balance_sheet.sql Show resolved Hide resolved
Katherine Chiodo and others added 2 commits January 24, 2023 13:27
@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for applying the updates @kchiodo! Our team is just starting a new sprint tomorrow. We will pick up this PR and work to bring these changes through then!

@fivetran-jamie
Copy link
Contributor

hey @kchiodo, hoping to merge in these changes soon! there are couple of updates we need to make to the PR though (the unresolved conversations with joe)... would you mind if i commit them directly here to your branch? wanted to check in case you're using this branch in production

@kchiodo
Copy link
Contributor Author

kchiodo commented Feb 2, 2023

hey @kchiodo, hoping to merge in these changes soon! there are couple of updates we need to make to the PR though (the unresolved conversations with joe)... would you mind if i commit them directly here to your branch? wanted to check in case you're using this branch in production

Feel free to make any changes needed. Thanks @fivetran-jamie

fivetran-jamie and others added 3 commits February 2, 2023 11:43
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-jamie fivetran-jamie changed the base branch from main to releases/v0.7.latest February 2, 2023 20:31
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all your work in applying this update @kchiodo and for helping with the review @fivetran-jamie

@fivetran-jamie fivetran-jamie merged commit f80d97d into fivetran:releases/v0.7.latest Feb 2, 2023
@fivetran-jamie fivetran-jamie mentioned this pull request Feb 2, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Affects most users; fix needed status:in_review Currently in review type:bug Something is broken or incorrect update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants