-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/update passthrough columns #60
Bugfix/update passthrough columns #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kchiodo thanks so much for taking the initiative to help our efforts and open a PR! 🎉
I was able to review your updates and have a small suggested edit within the CHANGELOG and a more open ended question within the netsuite__balance_sheet
model changes as I was unable to successfully run the branch without using the proposed edit.
In addition to the small edit and addressing the question for the balance sheet model, would you be able to index the package version within the dbt_project.yml and integration_tests/dbt_project.yml to be the new 0.7.1
version following this release.
Let me know if you have any questions!
Thanks for applying the updates @kchiodo! Our team is just starting a new sprint tomorrow. We will pick up this PR and work to bring these changes through then! |
hey @kchiodo, hoping to merge in these changes soon! there are couple of updates we need to make to the PR though (the unresolved conversations with joe)... would you mind if i commit them directly here to your branch? wanted to check in case you're using this branch in production |
Feel free to make any changes needed. Thanks @fivetran-jamie |
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all your work in applying this update @kchiodo and for helping with the review @fivetran-jamie
Are you a current Fivetran customer?
Yes, Fivetran customer from Maple
What change(s) does this PR introduce?
I adjusted the end models to properly pass through columns from the source package. Currently, the package only does this for Netsuite2
#44
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
❗🧨🤓