Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add subsidiary currency and transaction amount #150

Closed
2 of 4 tasks
jmongerlyra opened this issue Nov 27, 2024 · 4 comments
Closed
2 of 4 tasks

[Feature] Add subsidiary currency and transaction amount #150

jmongerlyra opened this issue Nov 27, 2024 · 4 comments
Labels
status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement

Comments

@jmongerlyra
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Please add the subsidiary currency and transaction amount to the balance sheet and income statement models. The fields are useful when reporting on amounts in the functional currency alongside the consolidated (i.e. converted_amount) results.

How would you implement this feature?

See related PR.

Describe alternatives you've considered

Adding the fields in a downstream repository. However, these would be useful for any customer using NetSuite One World.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

@fivetran-avinash
Copy link
Contributor

fivetran-avinash commented Nov 28, 2024

Hey @jmongerlyra , thanks for submitting this issue and concurrent PR!

Before proceeding forward, just wanted to check if you were able to leverage the balance_sheet_transaction_detail_columns and income_statement_transaction_detail_columns variable configuration you can use to pull transaction detail columns (see README details here)? Both transaction_amount and subsidiary_currency_symbol are available there, so wondering if you could test out that functionality and see if those figures match.

I do see that the transaction_amount logic might be different, so would be interested to see what your findings are if you try bringing in those values to the balance sheet and income statement. If they don't match your expectations, I think we can probably bring your PR in for review in a future sprint.

@jmongerlyra
Copy link
Contributor Author

@fivetran-avinash We included in the models directly because the sign of transaction_amount doesn't match converted_amount in the two models when passing through from transaction_details.

subsidiary_currency_symbol could be passed in. However, it made sense to include in the model directly since without it the currency of transaction_amount is unknown.

@fivetran-avinash
Copy link
Contributor

Thanks for the context @jmongerlyra ! We did some digging and agreed that using the *_transaction_detail_columns feature wouldn't necessarily work here as there is too much logic transformation that can disrupt the actual conversion of the data here.

So we think your suggestion works best and your request is well in scope to bring into a coming sprint. We plan to fold your updates into our next release of the dbt_netsuite package. We will let you know when we kick off work on this!

@fivetran-avinash fivetran-avinash added the status:accepted Scoped and accepted into queue label Dec 6, 2024
@fivetran-jamie
Copy link
Contributor

This is live in v0.17.0 of the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants