Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webnative 0.33 #2

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Webnative 0.33 #2

merged 5 commits into from
Aug 18, 2022

Conversation

icidasset
Copy link
Contributor

Changes for Webnative v0.33
Dropped support for Parcel v2

Copy link
Member

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working well with the latest webnative on icidasset/local-ipfs.

Left one note about simplifying the Vite config -- I think we will be alright with just the build.target config.

@@ -0,0 +1,14 @@
export default {
optimizeDeps: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this optimizeDeps block now that we bundling ipfs-core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly not, we'd still need this even with the bundled code.

@icidasset icidasset merged commit 3c055cb into main Aug 18, 2022
@icidasset icidasset deleted the icidasset/webnative-033 branch August 18, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants