Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bool unpivot #305

Merged
merged 4 commits into from
Dec 23, 2020
Merged

Bool unpivot #305

merged 4 commits into from
Dec 23, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Dec 14, 2020 •
edited
Loading

Opening in favor of #208 (stale PR)

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master — CC note: basing of the dev/ branch so we can prep a new release
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl mentioned this pull request Dec 14, 2020
Closed
@clrcrl clrcrl requested a review from jtcohen6 December 14, 2020 22:14
@clrcrl clrcrl merged commit 76db1b7 into dev/0.7.0 Dec 23, 2020
clrcrl pushed a commit that referenced this pull request May 18, 2021
@avishalom @clrcrl
Adding some logic to handle unpivoting boolean columns (#305)
4acbdd3 
Readme & deleted the 'remove' line which does nothing.

Finish off upivot boolean logic

Update changelog [ci skip]
clrcrl pushed a commit that referenced this pull request May 18, 2021
@avishalom @clrcrl
Handle boolean columns in unpivot macro (#305)
230d329 
Readme & deleted the 'remove' line which does nothing.

Finish off upivot boolean logic

Update changelog [ci skip]
clrcrl pushed a commit that referenced this pull request May 18, 2021
@avishalom @clrcrl
Handle boolean columns in unpivot macro (#305)
d4779ca 
Readme & deleted the 'remove' line which does nothing.

Finish off upivot boolean logic

Update changelog [ci skip]
clrcrl pushed a commit that referenced this pull request May 18, 2021
@avishalom @clrcrl
Handle boolean columns in unpivot macro (#305)
cb49fe4 
Readme & deleted the 'remove' line which does nothing.

Finish off upivot boolean logic

Update changelog [ci skip]
@joellabes joellabes deleted the bool_unpivot branch October 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clrcrl @avishalom