Refactor link_inbound_track function

Author: Michał Śledź

lib/membrane_rtc_engine/engine.ex

@@ -839,7 +839,20 @@ defmodule Membrane.RTC.Engine do
 
     state = put_in(state, [:filters, track_id], depayloading_filter)
     track = state.endpoints |> Map.fetch!(endpoint_id) |> Endpoint.get_track_by_id(track_id)
-    {links, state} = link_inbound_track(track_id, rid, track, endpoint_id, ctx, state)
+    {links, state} = create_tee_and_link(track_id, rid, track, endpoint_id, ctx, state)
+
+    # check for subscriptions for this track and fulfill them
+    {pending_track_subscriptions, pending_rest_subscriptions} =
+      Enum.split_with(state.pending_subscriptions, &(&1.track_id == track.id))
+
+    {links, state} =
+      Enum.flat_map_reduce(pending_track_subscriptions, state, fn subscription, state ->
+        fulfill_subscription(subscription, ctx, state)
+      end)
+
+    state = %{state | pending_subscriptions: pending_rest_subscriptions}
+
+    links = endpoint_to_tee_links ++ links
 
     spec = %ParentSpec{
       links: links,
@@ -925,7 +938,7 @@ defmodule Membrane.RTC.Engine do
     {:ok, state}
   end
 
-  defp link_inbound_track(track_id, rid, track, endpoint_id, ctx, state) do
+  defp create_tee_and_link(track_id, rid, track, endpoint_id, ctx, state) do
     tee =
       cond do
         rid != nil ->
@@ -959,16 +972,7 @@ defmodule Membrane.RTC.Engine do
       end
     ]
 
-    {pending_track_subscriptions, pending_rest_subscriptions} =
-      Enum.split_with(state.pending_subscriptions, &(&1.track_id == track.id))
-
-    {links, state} =
-      Enum.flat_map_reduce(pending_track_subscriptions, state, fn subscription, state ->
-        fulfill_subscription(subscription, ctx, state)
-      end)
-
-    state = %{state | pending_subscriptions: pending_rest_subscriptions}
-    {endpoint_to_tee_links ++ links, state}
+    {endpoint_to_tee_links, state}
   end
 
   defp check_subscription(subscription, state) do