Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in UG #1817

Closed
gforney opened this issue Jun 25, 2015 · 105 comments
Closed

typo in UG #1817

gforney opened this issue Jun 25, 2015 · 105 comments

Comments

@gforney
Copy link
Contributor

gforney commented Jun 25, 2015

FDS Version: 6
SVN Revision Number: 14948
Compile Date: March 4, 2013 ?
Smokeview Version/Revision:
Operating System:

Describe details of the issue below:


6.4.5 Special Topic : Initializing a 3D velocity field

-------- 5th line --------

To generate the a velocity initialization file with FDS, in.......
->
To generate the(or a) velocity initialization file with FDS, in.......

Original issue reported on code.google.com by springcb38 on 2013-03-04 11:19:27

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Thanks.

Original issue reported on code.google.com by drjfloyd on 2013-03-04 13:44:22

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

hellow! Sir, how to check the The Version Number of FDS?

Original issue reported on code.google.com by feyunyidai@126.com on 2013-03-14 13:07:46

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Type the name of the executable with no input file.

Original issue reported on code.google.com by mcgratta on 2013-03-14 13:09:27

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

(No text was entered with this change)

Original issue reported on code.google.com by drjfloyd on 2013-06-17 16:46:08

@gforney gforney closed this as completed Jun 25, 2015
@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

(No text was entered with this change)

Original issue reported on code.google.com by mcgratta on 2013-03-15 12:54:54

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

9.2.7 Louvered HVAC Vents
(in Guide)
...the keyword UVW on VENT. UWV is the...
(Typo)
...the keyword UVW on VENT. UVW is the...

Original issue reported on code.google.com by springcb38 on 2013-03-15 13:49:22

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

9.3.1 Specifying Pressure Zones
(in Guide)
A pressure zone can by any region within the computational......
(Typo)
A pressure zone can be any region within the computational......


9.3.1 Specifying Pressure Zones
(in Guide)
Example Case: Breaking Pressure Zones
This second point ought to be seen as a warning:
(Typo?)
:?


17.30
OUTLINE | Logical | Section 7.3.1. | .FALSE. |        |
=>
OUTLINE | Logical | Section 7.3.1. |         |.FALSE. |

Original issue reported on code.google.com by springcb38 on 2013-03-18 13:38:21

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Thank you again for your careful reading of the User's Guide.

Original issue reported on code.google.com by drjfloyd on 2013-03-18 14:38:50

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

10.3 Arrhenius Parameter Functions
(in Guide)
the pre-exponential is large and the activation is energy is 0,
(Typo)
the pre-exponential is large and the activation of energy is 0,

Original issue reported on code.google.com by springcb38 on 2013-03-19 14:04:43

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

11.1 Specifying Primitive Species
(in Guide)
Once defined that species can be tacked  as a single species and/or the species can
   used as part of one or more...
(Typo)
Once defined that species can be tracked as a single species and/or the species can
be used as part of one or more...


11.1 Specifying Primitive Species
(in Guide)
a primitive species with BACKGROUND=.TRUE. can be also be used
(Typo)
a primitive species with BACKGROUND=.TRUE. can also be used

Original issue reported on code.google.com by springcb38 on 2013-03-20 09:18:30

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

11.1.2 Specifying Gas and Liquid Species Properties
Option 2: User-Specified Properties
Two Gas Species with the Same Properties
(in Guide)
Note that the ID you provide for for a lumped species cannot ....
(Typo)
Note that the ID you provide for a lumped species cannot ....


11.1.2 Specifying Gas and Liquid Species Properties
Option 2: User-Specified Properties
Two Gas Species with the Same Properties
(in Guide)
If instead the primitive species ID was used, then the that output would sum ...
(Typo)
If instead the primitive species ID was used, then the output would sum ...


11.2 Specifying Lumped Species (Mixtures of Primitive Species)
(in Guide)
...individually. The parameters to defined a lumped species are::
(Typo)
...individually. The parameters to define a lumped species are::

Original issue reported on code.google.com by springcb38 on 2013-03-21 10:56:13

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Table 17.14
(in Guide)
INITIAL_UNMIXED_FRACION |   |   |1.0    |
(Typo)
INITIAL_UNMIXED_FRACION |   |   |   | 1.0

Original issue reported on code.google.com by springcb38 on 2013-03-22 16:36:17

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

12.3 Finite Rate Combustion
(in Guide)
The array SPEC_ID_N_S contains the list of species with the exponents, N_S, in Eq.
(12.14).
(Typo)
The array SPEC_ID_N_S contains the list of species with the exponents, N_S, in Eq.
(12.13).


12.4 Special Topic: Aerosol Deposition
(in Guide)
... QUANTITY='DEPOSITION VELOCITY' for a wall cell DEVC or with BNDF.
(Typo)
... QUANTITY='DEPOSITION VELOCITY' for a wall cell with DEVC or BNDF.


13.2.3 Wide Band Model
(in Guide)
the output QUANTITY 'ABSORPTION COEFFICIENT' output quantity becomes practically useless...
(Typo)
the output QUANTITY 'ABSORPTION COEFFICIENT' becomes practically useless...


14.3.4 Size Distribution
(Question)
What is the parameter CDF_CUTOFF ?


14.3.4 Size Distribution
(in Guide)
You can specify your own cumulative number fraction (CNF)2 by specifying a USER_CNF_RAMP
on the...
(Typo)
You can specify your own cumulative number fraction (CNF)2 by specifying a CNF_RAMP_ID
on the...


14.4.1 Basic Geometry and Boundary Conditions
(in Guide)
If the SURF line includes a MATL_ID, the particle mass will be based upon the value
or values of DENSITY of the ...
(Typo)
If the SURF line includes a MATL_ID, the particle mass will be based upon the value
of DENSITY of the ...

Original issue reported on code.google.com by springcb38 on 2013-03-24 14:14:42

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

14.4.7 Screens
(in Guide)
&PART ID='SCREEN', DRAG_LAW='SCREEN', ......, ORIENTATION(1:1,3)=1,0,0
(Typo)
&PART ID='SCREEN', DRAG_LAW='SCREEN', ......, ORIENTATION(1,1:3)=1,0,0

Original issue reported on code.google.com by springcb38 on 2013-03-25 12:40:41

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Thanks again.

Original issue reported on code.google.com by drjfloyd on 2013-03-25 13:00:39

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

17.30 VENT
(in Guide)
PBX, PBY, PBZ |Real |Section 7.3.1  |   |   |
(Typo)
PBX, PBY, PBZ |Real |Section 7.3.1  |m  |   |

Original issue reported on code.google.com by springcb38 on 2013-03-26 12:58:40

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Table 17.20 PROP
(in Guide)
LENGTH  |Real   |Section 15.3.5 |   |1.8
(Typo)
LENGTH  |Real   |Section 15.3.5 |m  |1.8


15.3.5 Smoke Detectors
Defining Smoke
(in Guide)
&SURF ID='SMOLDER', TMP_FRONT=1000., MASS_FLUX(1)=0.0001, COLOR='RED' /
(Typo?)
&SURF ID='SMOLDER', TMP_FRONT=1000., MASS_FLUX(1)=0.0001, SPEC_ID='MY SMOKE', COLOR='RED'
/

Original issue reported on code.google.com by springcb38 on 2013-03-28 12:21:12

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

thanks once again.  

Original issue reported on code.google.com by drjfloyd on 2013-03-28 18:24:47

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

15.4.2 Activating and Deactivating Vents
(in Guide)
the purpose is to either activate or deactivate any time ramp associated with the VENT
via its SURF_ID.
(Typo)
the purpose is to either activate or deactivate any time ramp associated with the VENT
via its DEVC_ID.


15.5.5 Control Function: CUSTOM
(in Guide)
&CTRL ID='cycling timer', FUNCTION_TYPE='CUSTOM, INPUT_ID='TIMER', RAMP_ID='cycle'
/
(Typo)
&CTRL ID='cycling timer', FUNCTION_TYPE='CUSTOM', INPUT_ID='TIMER', RAMP_ID='cycle'
/


Happy to do something for FDS6 !!

Original issue reported on code.google.com by springcb38 on 2013-03-29 11:07:36

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

15.5.3 Control Function: DEADBAND
(in Guide)
when the value of the INPUT_ID drops below the lower value in DEADBAND
(Typo)
when the value of the INPUT_ID drops below the lower value in SETPOINT

Original issue reported on code.google.com by springcb38 on 2013-04-01 11:58:34

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Chapter 16
Output
(in Guide)
It is important to remember that you must explicitly declare in the input file most
of the FDS output data.
(Question)
Above sentence is perfect ?


16.1 Output Control Parameters: The DUMP Namelist Group
(in Guide)
Note that DT_SLCF controls Smoke3D output.
(Typo)
Note that DT_SLCF controls SMOKE3D output.


16.1 Output Control Parameters: The DUMP Namelist Group
(in Guide)
EB_DUMP_FILE If .TRUE. write out the particle output file using 8 byte reals.
(Typo)
EB_DUMP_FILE If .TRUE., write out the particle output file using 8 byte reals.

Original issue reported on code.google.com by springcb38 on 2013-04-02 12:54:10

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

table 17.6
(in Guide)
DT_DEVC_LINE    | Real  | Section 16.2.2    |   | 1     |
(Typo)
DT_DEVC_LINE    | Real  | Section 16.2.2    | s | delta t / 4   |

Original issue reported on code.google.com by springcb38 on 2013-04-03 09:12:46

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

16.9.6 Particle Output Quantities
Solid Phase
(in Guide)
In this case case each grid cell on the floor....
(Typo)
In this case each grid cell on the floor....


16.9.6 Particle Output Quantities
Solid Phase
(in Guide)
analogous to actual buckets the size of a grid cell.
(Question)
Above sentence is perfect ?


Table 17.20
(Typo)
There is no PDPA_HISTOGRAM_LIMITS.

Original issue reported on code.google.com by springcb38 on 2013-04-09 13:28:22

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

9.2.5 HVAC Filter Parameters
(in Guide)
RAMP_ID identifies the RAMP that contains a table of pressure drop across the filter
as a function of total loading (see summation in LOSS.
(Typo?)
(summation in LOSS)  ?


Table 17.9
(in Guide)
LOADING_MULITPLIER  | Real Array    | Section 9.2.5 | kg    | 0.0
(Typo?)
LOADING_MULITPLIER  | Real Array    | Section 9.2.5 | kg^-1 | 0.0

K_filter = K_CLEAN_LOSS + K_LOSS sum(Li Mi) (9.2.5 HVAC Filter Parameters)

K_filter : implicitly in FDS code (non-dimensional)
K_CLEAN_LOSS : CLEAN_LOSS (non-dimensional)
K_LOSS : LOSS (non-dimensional)
Li : LOADING (kg)
Mi : LOADING_MULTIPLIER (kg? -> kg^-1)

Original issue reported on code.google.com by springcb38 on 2013-04-12 09:02:11

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Y_CO2_INFTY=0.0058(manual) ? 0.000595(code)
Y_O2_INFTY=0.232428(manual) ? 0.232378(code)

MAX_PRESSURE_ITERATIONS=10000(manual)? 10(code)

Which is correct?

(In this issue site, I didn't get a response in case of such a question. Please reply
to me via mail.)
Thank you ~

Original issue reported on code.google.com by springcb38 on 2013-04-25 04:12:55

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

LES_FILTER_WIDTH = 'MAX' (manual) ? 'MEAN' (code)

Which is correct?

Original issue reported on code.google.com by springcb38 on 2013-04-25 06:08:45

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Thank you.

Original issue reported on code.google.com by drjfloyd on 2014-07-24 11:57:02

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

In FDS+Evac User's Guide,

34page, 
    door widht -> door width

74page, 8.1 The MESH Namelist Group
    NO_EVACUATION is set to .FALSE. -> NO_EVACUATION is set to .TRUE.

78page, 8.6 The HOLE Namelist Group
    for all evacuation mesh obstacles, -> for all evacuation mesh holes,

Original issue reported on code.google.com by springcb38 on 2015-02-10 10:46:23

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

INITIAL_VALUE is not a keyword on &CTRL namelist.

FDS User Guide 187page,
15.5.3 Control Function: DEADBAND

INITIAL_VALUE
-> initial value

Original issue reported on code.google.com by springcb38 on 2015-04-21 05:29:01

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

User's Guide, 14.4.4

For the cylinder, the area is twice the radius times the length
=>
For the cylinder, the area is 2pi times the radius times the length

Original issue reported on code.google.com by springcb38 on 2015-04-27 04:44:35

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

I fixed the typo mentioned in #81.

Original issue reported on code.google.com by mcgratta on 2015-04-27 13:47:18

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Are there any comments in this issue that have not been addressed? If so, start a new
issue. There might be more than one person needed to respond.

Original issue reported on code.google.com by mcgratta on 2015-04-27 13:52:00

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

If Project Member make comment, I just thought that all my comments above that had been
resolved.

I did not check whether typo was fixed or not.

Original issue reported on code.google.com by springcb38 on 2015-04-28 02:32:53

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

read.f90
subroutine READ_DEVC
           :
      DV%CTRL_ID           = CTRL_ID
      DV%DEVC_ID           = DEVC_ID
      DV%CTRL_ID           = CTRL_ID
           :

"DV%CTRL_ID = CTRL_ID" line is repeated.

Original issue reported on code.google.com by springcb38 on 2015-05-10 06:57:22

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

read.f90
subroutine READ_DEVC
            :
       DV%CTRL_ID           = CTRL_ID
       DV%DEVC_ID           = DEVC_ID
       DV%CTRL_ID           = CTRL_ID
            :

"DV%CTRL_ID = CTRL_ID" line is repeated.


I fixed this.

Original issue reported on code.google.com by mcgratta on 2015-05-11 14:07:28

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

The procedure of the subroutine call in read.f90 is the same with below.
       :
CALL READ_MESH(1) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_EVAC(1) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_MESH(2) ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_TRAN    ; IF (STOP_STATUS==SETUP_STOP) RETURN
CALL READ_TIME    ; IF (STOP_STATUS==SETUP_STOP) RETURN
       :
Then, following is described at subroutine READ_TIME.

IF (.NOT.SYNCHRONIZE) SYNC_TIME_STEP = .FALSE.

This means that .not.SYNCHRONIZE on &TIME forces all SYNCHRONIZE on &MESH to .FALSE.


However, in user guide,

"It is also possible to synchronize the time step in only a select set of meshes. To
do this, add SYNCHRONIZE=.TRUE. to the appropriate MESH lines and then add SYNCHRONIZE=.FALSE.
to the TIME line."


There is inconsistency between source code and user's guide.

Original issue reported on code.google.com by springcb38 on 2015-05-18 12:29:15

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Thanks. We plan to remove the SYNCHRONIZATION option, which will fix this inconsistency.

Original issue reported on code.google.com by mcgratta on 2015-05-28 20:55:00

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

default value of SURFACE_TENSION in U.G
7.28e4
->
7.28e-2

Original issue reported on code.google.com by springcb38 on 2015-05-29 11:47:49

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Do you plan to remove the SYNCHRONIZATION option ?
So,
SYNCHRONIZE=.FALSE. is implicitly applied ?

Original issue reported on code.google.com by springcb38 on 2015-05-29 11:50:07

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

No, SYNCHRONIZE=.TRUE.; that is, all meshes use the same time step.

Original issue reported on code.google.com by mcgratta on 2015-05-29 12:58:31

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

read.f90

TAU_PART= 0._EB
-> 
TAU_PART=1.0_EB (by User's Guide)

Original issue reported on code.google.com by springcb38 on 2015-06-15 02:32:32

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

hvac.f90

SUBROUTINE SET_HVAC_DEFAULTS
   : 
COOLANT_TEMPERATURE = 293.15_EB 

->
COOLANT_TEMPERATURE = 0._EB 


Original issue reported on code.google.com by springcb38 on 2015-06-15 04:22:11

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

->
COOLANT_TEMPERATURE = 20._EB 

Original issue reported on code.google.com by springcb38 on 2015-06-15 04:23:31

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

fixed coolant temperature.


Original issue reported on code.google.com by drjfloyd on 2015-06-15 13:36:01

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

what about #92 ?

Original issue reported on code.google.com by springcb38 on 2015-06-16 00:11:47

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

Kevin,

Any reason we have TAU_PART=0 in the source?  Should we change the source or the  guide
for this one?

Jason

Original issue reported on code.google.com by drjfloyd on 2015-06-16 17:48:29

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

My guess is that we set it to zero to satisfy some verification case. I would set it
to 1 in the source, just to be consistent with other ramped quantities.

Original issue reported on code.google.com by mcgratta on 2015-06-16 18:29:17

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

changed TAU_PART to 1.

Original issue reported on code.google.com by drjfloyd on 2015-06-17 12:20:25

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<source code>
OUTPUT_QUANTITY(161)%NAME = 'ASPIRATION'
OUTPUT_QUANTITY(161)%UNITS = '%/m' 

<User guide>
ASPIRATION Section 15.3.7 %
->
ASPIRATION Section 15.3.7 %/m



Original issue reported on code.google.com by springcb38 on 2015-06-18 01:15:11

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<User guide>
FRICTION VELOCITY Section 16.10.14       B,D
->
FRICTION VELOCITY Section 16.10.14  m/s  B,D

Original issue reported on code.google.com by springcb38 on 2015-06-18 01:25:47

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<User guide>
SOLID SPECIFIC HEAT Section 16.2.3 kJ/(m·K) D
->
SOLID SPECIFIC HEAT Section 16.2.3 kJ/(kg·K) D

Original issue reported on code.google.com by springcb38 on 2015-06-18 01:51:05

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<User guide>
MAXIMUM VELOCITY ERROR Section 6.6         D
->
MAXIMUM VELOCITY ERROR Section 6.6   m/s   D

Original issue reported on code.google.com by springcb38 on 2015-06-18 02:03:34

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<User guide>
NORMALIZED MASS LOSS RATE  Section 16.10.8 1/s B,D
->
NORMALIZED MASS LOSS RATE* Section 16.10.8 1/s B,D

Original issue reported on code.google.com by springcb38 on 2015-06-18 02:07:14

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

fixed 100-104

Original issue reported on code.google.com by drjfloyd on 2015-06-18 11:19:56

@gforney
Copy link
Contributor Author

gforney commented Jun 25, 2015

<User Guide>
C_FACTOR Real Section 15.3.1                0.
=>
C_FACTOR Real Section 15.3.1   (m/s)^1/2    0.

Original issue reported on code.google.com by springcb38 on 2015-06-23 07:09:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant