Data Importer exits with error code 1 when no transactions are found #9357
Comments
|
Hey, thanks for opening an issue! I remember somebody wanted specifically to exit 1 when no no transactions were found or imported or whatever so that's what I did. It made sense at the time. I could change to exit code 2 or something like that, I'll think about it! |
|
I can see this being useful in certain situations yeah. Thanks for the quick response, let me know if you need anything else from my side |
|
The Exit codes are documented here: https://docs.firefly-iii.org/how-to/data-importer/advanced/cli/ |
|
Hi there! This is an automatic reply. This issue is now 🔒 closed. Please be aware that closed issues are not monitored by the developer of Firefly III.
If there is more to discuss, please open a new issue or discussion. Thank you for your contributions. |
Support guidelines
I've found a bug and checked that ...
Description
When importing from GoCardless, if an account has transactions but they are all out of the filter range (or if they don't have transactions in the last 90 days at all), the data importer will exit with error code 1.
I've upgraded from 1.4.2 to 1.5.6 and this started happening (I vaguely remember this being a problem in the past that was fixed, so this might be a regression).
I'm aware that this might be intended behavior. If that's the case, feel free to dismiss this issue as I have a workaround for it (see additional information section).
Debug information
Debug information generated at 2024-10-17 10:01:58 Europe/Amsterdam for Firefly III Data Importer version 1.5.6.
Expected behaviour
If there are no transactions, I would still expect the exit code to be 0 if there was no actual error talking to GoCardless.
Steps to reproduce
Probably not very useful, but this is my JSON config for that specific account:
{ "date": "", "default_account": 1, "delimiter": "comma", "headers": false, "rules": true, "skip_form": false, "add_import_tag": true, "roles": [], "do_mapping": [], "mapping": [], "duplicate_detection_method": "classic", "ignore_duplicate_lines": false, "ignore_duplicate_transactions": true, "unique_column_index": 0, "unique_column_type": "external-id", "version": 3, "flow": "nordigen", "identifier": "0", "connection": "0", "ignore_spectre_categories": false, "map_all_data": false, "accounts": { "REDACTED": 1 }, "date_range": "partial", "date_range_number": 5, "date_range_unit": "d", "date_not_before": "2022-02-23", "date_not_after": "2022-02-23", "nordigen_country": "REDACTED", "nordigen_bank": "REDACTED", "nordigen_requisitions": { "REDACTED": "REDACTED" }, "conversion": false }If there are no transactions in the last 5 days, exit code of the importer is 1.
Additional info
Log (slightly redacted):
I've fixed this on my side by making the no transactions error a warning instead: diogotcorreia/dotfiles@399f824#diff-19cd1f20eb3f5b530f5ad59217e4f13e68b6fced9575624b2787b4fcb725b795 (file
0001-no-transactions-warning-instead-of-error.diff).The text was updated successfully, but these errors were encountered: