-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not save "similar rules" #103
Comments
@zStupan, what do you think? |
@mlaky88, what is your opinion? |
This would definitely help. It could maybe be implemented by using a similarity threshold. For example, check each boundary for numerical attributes for generated rules, and compare to existing archive. If lower and upper boundaries off all attributes are within the threshold, the reject the rule. |
@zStupan, what do you think? |
Is there maybe any progress? This would be really beneficial, and raise the overall quality of the mined rules. |
I apologize, I've been very busy. I'll get to work on this ASAP. |
Ok, in #109 I've changed the way attributes get compared. Now, if 2 numerical attributes' bounds match up to 6 decimals, they're considered equal. There doesn't seem to be much of a difference in the number of rules generated though. |
The current version of NiaARM includes each distinctive rule in the archive of identified rules. However, many numerical rules can be viewed as the same since there are only differences on the 7 or 8 eighth decimal.
To solve this "issue," I recommend that when storing a new rule in an archive, we check whether a similar rule is already included.
The text was updated successfully, but these errors were encountered: