Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save "similar rules" #103

Closed
firefly-cpp opened this issue Nov 16, 2023 · 8 comments · Fixed by #109
Closed

Do not save "similar rules" #103

firefly-cpp opened this issue Nov 16, 2023 · 8 comments · Fixed by #109
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@firefly-cpp
Copy link
Owner

The current version of NiaARM includes each distinctive rule in the archive of identified rules. However, many numerical rules can be viewed as the same since there are only differences on the 7 or 8 eighth decimal.

To solve this "issue," I recommend that when storing a new rule in an archive, we check whether a similar rule is already included.

@firefly-cpp
Copy link
Owner Author

@zStupan, what do you think?

@firefly-cpp
Copy link
Owner Author

@mlaky88, what is your opinion?

@mlaky88
Copy link
Collaborator

mlaky88 commented Nov 20, 2023

This would definitely help. It could maybe be implemented by using a similarity threshold. For example, check each boundary for numerical attributes for generated rules, and compare to existing archive. If lower and upper boundaries off all attributes are within the threshold, the reject the rule.

@firefly-cpp
Copy link
Owner Author

@zStupan, what do you think?

@mlaky88
Copy link
Collaborator

mlaky88 commented Jan 25, 2024

Is there maybe any progress? This would be really beneficial, and raise the overall quality of the mined rules.

@firefly-cpp firefly-cpp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 25, 2024
@zStupan
Copy link
Collaborator

zStupan commented Jan 27, 2024

I apologize, I've been very busy. I'll get to work on this ASAP.

@zStupan
Copy link
Collaborator

zStupan commented Feb 9, 2024

Ok, in #109 I've changed the way attributes get compared. Now, if 2 numerical attributes' bounds match up to 6 decimals, they're considered equal. There doesn't seem to be much of a difference in the number of rules generated though.

@firefly-cpp
Copy link
Owner Author

@mlaky88: @zStupan has already implemented this feature. Please update to the recent 0.3.7 release and try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants