Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_messaging] Management of data messages when activity is killed #829

Closed
kroikie opened this issue Oct 13, 2019 · 9 comments
Closed
Labels

Comments

@kroikie
Copy link
Collaborator

kroikie commented Oct 13, 2019

If the app is in a killed state and a data message is sent, the app will call the onMessageReceived of the FlutterFirebaseMessagingService, but since the Activity is killed the FirebaseMessagingPlugin can not respond to the intent and the message is lost.

This is a problem when somebody wants to perform an action depending on the data which is contained in a message.

Are there any plans to handle this kind of behaviour?

@kroikie
Copy link
Collaborator Author

kroikie commented Oct 13, 2019

@jankuss

The issue at flutter/flutter#17482 has been closed and moved here. Future collaboration on this issue will be done here.

@iapicca
Copy link

iapicca commented Oct 22, 2019

Hi @jankuss
If you are still experiencing this issue
with the latest version of Flutter and FlutterFire plugin
can you please provide your updated flutter doctor -v
and your and your flutter run --verbose/flutter build --verbose ?
Also, to better address the issue, would be helpful
if you could post a self contained app on github
or the steps to reproduce it.
Thank you

#53
#1055
#766
#508

@iapicca iapicca added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Oct 23, 2019
@iapicca iapicca changed the title firebase_messaging: Management of data messages when activity is killed [firebase_messaging] Management of data messages when activity is killed Oct 23, 2019
@iapicca
Copy link

iapicca commented Nov 20, 2019

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v' please.
All system setups can be slightly different so its always better to open new issues and reference related issues.

@iapicca iapicca closed this as completed Nov 20, 2019
@creativecreatorormaybenot
Copy link
Contributor

@iapicca I am afraid I do not understand why you would close this. This is a feature request rather than a bug report.

@kroikie
Copy link
Collaborator Author

kroikie commented Nov 21, 2019

@iapicca I believe that this will be resolved once the migration of the firebase_messaging plugin to use the v2 embedding for Android. I'll reopen this and then close once that migration is complete.

@kroikie kroikie reopened this Nov 21, 2019
@creativecreatorormaybenot
Copy link
Contributor

@kroikie Is this currently being worked on or what PR do I need to follow?

@kroikie
Copy link
Collaborator Author

kroikie commented Dec 3, 2019

@creativecreatorormaybenot no PR yet but it is being worked on, sorry for the delay here.

@iapicca iapicca added type: enhancement New feature or request and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Jan 28, 2020
@cmaster11
Copy link

@creativecreatorormaybenot no PR yet but it is being worked on, sorry for the delay here.

@kroikie , do you have a reference to an issue/milestone/anything related to this migration?

@Salakar
Copy link
Member

Salakar commented Nov 5, 2020

Hey all 👋

As part of our roadmap (#2582) we've just shipped a complete rework of the firebase_messaging plugin that aims to solve this and many other issues. As far as I can tell this is now supported by using the onBackgroundMessage API which is not tied to an Activity.

If you can, please try out the dev release (see the migration guide for upgrading and for changes) and if you have any feedback then join in the discussion here.

Given the scope of the rework I'm going to go ahead and close this issue in favor of trying out the latest plugin.

Thanks everyone.

@Salakar Salakar closed this as completed Nov 5, 2020
@firebase firebase locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants