Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UX polish for enabling/disabling functions #3203

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

samtstern
Copy link
Contributor

Description

Two changes:

  • Prevents log spam about "disabling" functions that are already disabled (old trigger generations) when functions are repeatedly enabled/disabled.
  • Makes disabling wait for the work queue to flush so that no functions appear to run after the disabled message returns success.

Scenarios Tested

Tested both of these with the emulators codelab.

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Mar 11, 2021
@samtstern samtstern requested a review from yuchenshi March 11, 2021 12:10
@yuchenshi
Copy link
Member

CHANGELOG please

@samtstern samtstern merged commit 6c03c99 into master Mar 11, 2021
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
@bkendall bkendall deleted the ss-disable-functions-polish branch August 4, 2021 19:26
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants