From b7c8383189261bd65c8d62974f3a61629b5e158e Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Tue, 10 Oct 2023 12:42:18 -0700 Subject: [PATCH] Rename frameworks experiment to internalframeworks to avoid confusion. (#6439) * Rename frameworks experiment to internalframeworks to avoid confusion. * Missed a spot. --- src/commands/init.ts | 6 +++--- src/experiments.ts | 2 +- src/init/index.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/commands/init.ts b/src/commands/init.ts index 4987bc82e65..8ac0cbfd55a 100644 --- a/src/commands/init.ts +++ b/src/commands/init.ts @@ -73,9 +73,9 @@ const choices = [ }, ]; -if (isEnabled("frameworks")) { +if (isEnabled("internalframeworks")) { choices.push({ - value: "frameworks", + value: "internalframeworks", name: "Frameworks: Get started with Frameworks projects.", checked: false, }); @@ -85,7 +85,7 @@ const featureNames = choices.map((choice) => choice.value); const DESCRIPTION = `Interactively configure the current directory as a Firebase project or initialize new features in an already configured Firebase project directory. -This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory. +This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory. To initialize a specific Firebase feature, run 'firebase init [feature]'. Valid features are: ${[...featureNames] diff --git a/src/experiments.ts b/src/experiments.ts index 0d61ba57082..c5f96a03757 100644 --- a/src/experiments.ts +++ b/src/experiments.ts @@ -98,7 +98,7 @@ export const ALL_EXPERIMENTS = experiments({ "without a notice.", }, - frameworks: { + internalframeworks: { shortDescription: "Allow CLI option for Frameworks", default: true, public: false, diff --git a/src/init/index.ts b/src/init/index.ts index e3b7557b4df..419412738a6 100644 --- a/src/init/index.ts +++ b/src/init/index.ts @@ -32,8 +32,8 @@ const featureFns = new Map P ["hosting:github", features.hostingGithub], ]); -if (isEnabled("frameworks")) { - featureFns.set("frameworks", features.frameworks); +if (isEnabled("internalframeworks")) { + featureFns.set("internalframeworks", features.frameworks); } export async function init(setup: Setup, config: any, options: any): Promise {