Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function in Auth interface #574

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Add missing function in Auth interface #574

merged 1 commit into from
Mar 19, 2018

Conversation

gonzaloriestra
Copy link
Contributor

Related to issue #573.

Added the TypeScript definition for the createUserAndRetrieveDataWithEmailAndPassword function in Auth interface.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@gonzaloriestra
Copy link
Contributor Author

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gonzaloriestra! This LGTM 👍

@jshcrowthe jshcrowthe merged commit 9d00c6f into firebase:master Mar 19, 2018
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants