Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmet peer dependencies @firebase/app-types #1207

Closed
AdrienLemaire opened this issue Sep 6, 2018 · 8 comments
Closed

unmet peer dependencies @firebase/app-types #1207

AdrienLemaire opened this issue Sep 6, 2018 · 8 comments

Comments

@AdrienLemaire
Copy link

[REQUIRED] Describe your environment

  • Operating System version: arch linux
  • Firebase SDK version: 5.4.2
  • Firebase Product: auth
  • react-redux-firebase 2.1.8

[REQUIRED] Describe the problem

Steps to reproduce:

Relevant Code:

When installing my packages with yarn, I get:

[2/2] Regenerating lockfile and installing missing dependencies...
info fsevents@1.2.4: The platform "linux" is incompatible with this module.
info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
warning "firebase > @firebase/database@0.3.4" has unmet peer dependency "@firebase/app-types@0.x".
warning "firebase > @firebase/firestore@0.7.2" has unmet peer dependency "@firebase/app-types@0.x".
warning "firebase > @firebase/functions@0.3.0" has unmet peer dependency "@firebase/app-types@0.x".
warning "firebase > @firebase/messaging@0.3.5" has unmet peer dependency "@firebase/app-types@0.x".
warning "firebase > @firebase/storage@0.2.3" has unmet peer dependency "@firebase/app-types@0.x".
warning "firebase > @firebase/auth > @firebase/auth-types@0.3.4" has unmet peer dependency "@firebase/app-types@0.x".                                                                                                           
warning "firebase > @firebase/database > @firebase/database-types@0.3.2" has unmet peer dependency "@firebase/app-types@0.x".                                                                                                   
warning "firebase > @firebase/firestore > @firebase/firestore-types@0.6.0" has unmet peer dependency "@firebase/app-types@0.x".                                                                                                 
warning "firebase > @firebase/functions > @firebase/messaging-types@0.2.3" has unmet peer dependency "@firebase/app-types@0.x".                                                                                                 
warning "firebase > @firebase/storage > @firebase/storage-types@0.2.3" has unmet peer dependency "@firebase/app-types@0.x".                                                                                                     
warning " > eslint-import-resolver-babel-plugin-root-import@1.1.1" has incorrect peer dependency "babel-plugin-root-import@^5.1.0".          

Maybe related: #752, #388

Doesn't seem to have any bad effect on the product. And since we're installing firebase instead of @firebase/auth and other required components, I don't think this is an issue related to my environment.

@Feiyang1
Copy link
Member

After a quick google search, It appears to be a known issue with yarn. If a peer dependency is installed by a dependency's dependency (I know it's a mouthful), yarn will complain about it. Your product is totally safe, there is nothing to worry about.
You can also use npm install instead, and there is no warning.

@mackelito
Copy link

@Feiyang1 for reference, please add link to that known bug in yarn if possible.. for me I can never just leave a warning unless I have confirmation and have tracking on the issue :)

@Feiyang1
Copy link
Member

There you go, yarnpkg/yarn#5347
Yarn thinks it's working as expected, so I doubt it will get fixed. It won't be a problem in our use case, since "@firebase/app-types@0.x" is a dependency of "@firebase/app" which is always required.

@mackelito
Copy link

Well.. one could just install the types and be gone with it :D
yarn add @firebase/app-types@0.x --dev

@antoinerousseau
Copy link

So if it isn't Yarn's fault, this issue should be reopened

@PutziSan
Copy link

I'd also say that's not solved. The "more obvious" solution would be to remove "@firebase/app-types@0.x" as peerDependency and add it as normal dependency?

@garyo
Copy link

garyo commented Feb 26, 2019

This is biting me as well. The warnings look dangerous even though my app is working fine.

@arpowers
Copy link

@Feiyang1 Is there a reason you can't move the peerDependencies causing this issue to dependencies? That's the consensus at Yarn.

yarnpkg/yarn#5347

@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants