-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmet peer dependencies @firebase/app-types #1207
Comments
After a quick google search, It appears to be a known issue with yarn. If a peer dependency is installed by a dependency's dependency (I know it's a mouthful), yarn will complain about it. Your product is totally safe, there is nothing to worry about. |
@Feiyang1 for reference, please add link to that known bug in yarn if possible.. for me I can never just leave a warning unless I have confirmation and have tracking on the issue :) |
There you go, yarnpkg/yarn#5347 |
Well.. one could just install the types and be gone with it :D |
So if it isn't Yarn's fault, this issue should be reopened |
I'd also say that's not solved. The "more obvious" solution would be to remove "@firebase/app-types@0.x" as peerDependency and add it as normal dependency? |
This is biting me as well. The warnings look dangerous even though my app is working fine. |
@Feiyang1 Is there a reason you can't move the peerDependencies causing this issue to dependencies? That's the consensus at Yarn. |
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
Steps to reproduce:
Relevant Code:
When installing my packages with yarn, I get:
Maybe related: #752, #388
Doesn't seem to have any bad effect on the product. And since we're installing
firebase
instead of@firebase/auth
and other required components, I don't think this is an issue related to my environment.The text was updated successfully, but these errors were encountered: