Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] For macOS, don't unnecessarily stub out iOS+ SDK #934

Open
cpsauer opened this issue May 6, 2022 · 5 comments
Open

[FR] For macOS, don't unnecessarily stub out iOS+ SDK #934

cpsauer opened this issue May 6, 2022 · 5 comments
Labels

Comments

@cpsauer
Copy link
Contributor

cpsauer commented May 6, 2022

Hey wonderful Firebase folks,

The iOS+ SDK these days has pretty broad support for macOS. But on quick inspection, it looks like a lot of that functionality, e.g., Analytics, is unnecessarily stubbed out in this C++ SDK.

Could you fix that? It seems like it wouldn't be that hard to change the build to pipe it through, same as tvOS, since the underlying pieces are there.

Thanks for your consideration!
Chris
(ex-Googler)

P.S. If it's already supported--and I've missed it, then please correct me, and my apologies in advance.
P.P.S. #234 is related in that both involve desktop analytics support, but this issue differs in that it should be quite easy to add macOS support more broadly, since it's already supported by an underlying platform SDK.

@google-oss-bot google-oss-bot added the type: feature request New feature or request label May 6, 2022
@AlmostMatt
Copy link
Contributor

Hi Chris,

As you mentioned the iOS+ SDK now supports many things that are otherwise just stubs in the macOS version of the C++ SDK

I don't think I can confirm any details or timelines yet, but this is definitely something that we are considering and looking into. It will be great if we can indeed make use of the iOS SDK to improve our coverage of the C++ SDK on macOS.

@cpsauer
Copy link
Contributor Author

cpsauer commented May 10, 2022

Thanks for your quick reply, @AlmostMatt. Super excited for whatever might be coming. And I really appreciate your confirming that it's on your radar.
Could I ask that you keep us posted on your plans, as much as is allowed?

[Musing: I think this might be the type of product/feature where secrecy doesn't serve Google as well as transparency. It's not like phones where people will buy fewer today if they know what features are coming that they'd wait for. Instead, people are more likely to use Firebase if they know what exciting things are coming! (Nor, presumably do you need to be worried about people copying this feature.) This twitter exchange got me thinking about it originally.]

@cpsauer cpsauer changed the title FR: For macOS, don't unnecessarily stub out iOS+ SDK [FR] For macOS, don't unnecessarily stub out iOS+ SDK May 10, 2022
@jonsimantov
Copy link
Contributor

As all of our development on the C++ SDK is done in this open-source repo now, I wouldn't say it's a matter of secrecy, more just that we can't commit to when we'd be able to start working on expanded macOS desktop support. I definitely want to see it happen, it's more a question of prioritization and resources than anything else.

Of course, being an open-source repo, we are always open to external contributions... :)

@cpsauer
Copy link
Contributor Author

cpsauer commented May 10, 2022

Indeed! Fair enough. Expectation management is important for sure.

May well get there--and just tossed up an unrelated mini (but useful) PR for fun--but I think I should get things set up and rolling on mobile for my team first.
(I do contribute fairly heavily to Google open source, but this one's also a commercial product, and I think more of a your-guys'-configuration kinda thing.)

@cpsauer
Copy link
Contributor Author

cpsauer commented May 10, 2022

Heh, and wow, you'd already merged it. That's pretty awesome. Thanks @jonsimantov!

Pretty sweet profile pic, too :)

@AlmostMatt AlmostMatt removed the new New issue. label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants