Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileFormat 2 breaks time series in webrtc-dump-importer #277

Open
johnryan opened this issue Aug 13, 2019 · 2 comments
Open

fileFormat 2 breaks time series in webrtc-dump-importer #277

johnryan opened this issue Aug 13, 2019 · 2 comments

Comments

@johnryan
Copy link

It looks like the fileFormat 2 causes the time series to render incorrectly:

This is rendered with the fileFormat v2:
Screen Shot 2019-08-12 at 10 47 44 PM

If I remove the "fileFormat":2 in the extracted file it seems to render correctly:
Screen Shot 2019-08-12 at 10 47 33 PM

Is this a known issue / expected behavior / user error?

Thanks!

@fippo
Copy link
Owner

fippo commented Aug 13, 2019

works for me. The graph looks as if stats[id].timestamp is undefined in https://github.com/fippo/webrtc-dump-importer/blob/gh-pages/rtcstats.html#L357 - which could happen if you use a v1 js with a server that assumes v2

@johnryan
Copy link
Author

@fippo Interesting, should the server be checking the client version before writing the fileFormat: 2 parameter? Interestingly I also saw this behavior with the output from running npm run test is the seed data for that still in the legacy format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants