Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Thymeleaf #740

Open
takeoss39 opened this issue Feb 4, 2023 · 1 comment
Open

Support Thymeleaf #740

takeoss39 opened this issue Feb 4, 2023 · 1 comment

Comments

@takeoss39
Copy link

Feature Request

Description of Problem:

We have a lot of Thymeleaf assets, so we made a custom template engine using Thymeleaf .
But when the BDK is updated, these custom components also need to follow the details. (e.g. #686)
When Thymeleaf is supported natively by the BDK, we can safely update to the latest BDK, so we can concentrate on creating bots.

@ystxn
Copy link
Member

ystxn commented Feb 8, 2023

@takeoss39 we have not received any demand from the community to support thymeleaf within BDK core, so it would be difficult to commit resources into building this.

I can assure you that #686 is a rare occurence and we will likely not touch the templating engine much in the future. That was actually the only change since the inception of BDK. You can supply an empty implementation for the new inline method for your thymeleaf engine if you do not use that feature just so you can use the new BDK.

Alternatively, you can also contribute that integration as a Pull Request into this repository so that in the unlikely event we need to modify the parent templating engine again, we would need to update the Thymeleaf engine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants