Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels, Feeds & Transactions Discussion group 30th Nov 2021 #517

Closed
11 tasks
kriswest opened this issue Nov 30, 2021 · 10 comments
Closed
11 tasks

Channels, Feeds & Transactions Discussion group 30th Nov 2021 #517

kriswest opened this issue Nov 30, 2021 · 10 comments
Labels
channels feeds & transactions Channels, Feeds & Transactions Discussion Group help wanted Extra attention is needed meeting

Comments

@kriswest
Copy link
Contributor

kriswest commented Nov 30, 2021

Group overview

There are currently 10 open issues in the FDC3 repository , under consideration for the 2.0 release, that relate to the existing concept of channels (both the 'system channels' used via the desktop agent API, and 'app channels' interacted with through the Channels API) and new concepts we've discussed introducing: transactions (a standardized way to make a request and receive a response back) and feeds (a standardized way to request a stream of data, such as a pricing stream).

Relevant issue tags

Current open issues that relate to the above concepts with the label:

Meeting Date

Tuesday 30th Nov 2021 - 9am EST / 2pm GMT

WebEx info

  • Meeting Link
    Meeting number: 2555 313 2702
    Password: k8fRjAqQM62

More ways to join

  • Join by video system:
  • Join by phone
    • +1-415-655-0003 US Toll
    • +44-20319-88141 UK Toll
  • Access code: 255 531 32702

Meeting notices

  • FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

  • All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

  • FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.

  • FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

  • A Discussion Group has no direct decision-making power regarding the FDC3 standard - rather it is intended that anything they propose or work on will result in proposals (via Github issues and PRs) for the Standards Working Group participants to consider and vote on for inclusion in the standard. As such, participation in a Discussion group is not required for contributing to any particular issue or FDC 2.0 as a whole.

Agenda

Minutes

  • @kriswest provided an introduction to two new issues raised and encouraged participants to comment on the issue threads:
  • Clarification of process for PRs -> SWG was requested by a participant:
    • @kriswest to create a summary of all open PRs from this group (with diagrams for the less technical) for next SWG meeting in 2 weeks
    • The maintainers will then wait a month for input (and for the maintainers to review the PRs) before merging the changes if there are no objections or further discussion
  • @kriswest to highlight any controversial elements in PRs raised/examined in this meeting within the meeting minutes for non-attendees to review (see below)
  • Add the concept of a feed or stream to FDC3 to handle use-cases not covered by channels or intents #433
    • PR: 433 Feeds: PrivateChannels and returning channels from intents #508
    • Take note of when reviewing:
      • PR is built on top of other PRs currently open, so not all the changes shown are specific to this PR
      • There was some discussion of whether you should createPrivateChannel() and return it or whether the desktop agent should just always create one for a raised intent automatically
        • Meeting participants observed that:
          • The Desktop Agent would not know whether a channel is needed and that they would proliferate on all raised intents.
          • IntentResolution.getResult() would have to be split into getData() and getChannel()
          • You'd be able to return both data and a channel from one intent, which is unintended.
      • findIntent supports resolution with a specified return type.
        • This can be channel or channel<context type> (e.g. channel<fdc3.instrument>) if you want a channel back.
        • Is this needed?
  • Allow intents to be targeted at specific instances of apps #450
    • PR: 450 allow intents to target app instances #509
    • Take note of when reviewing:
      • optional fdc3.findInstances() API call
        • use-case: to establish if a copy of an app has been launched already - without having to findIntent and have an intent/context handy
      • AppMetadata.instanceMetadata: Record<string,any> field added to support additional data to help identify instance to user in a UI
        • This is in addition to AppMetadata.instanceId
        • No standard fields proposed (implementation-specific),
        • Desktop agents don't really need it (as they could get at any such data themselves).
        • Such data is mainly useful if you want to create your own resolver within an app.
        • A meeting participant suggested manipulating AppMetadata.title instead (e.g. "My App (top left on monitor 3)") and suggest that we remove the suggested field from the PR
        • Another meeting participant suggested that an optional recommendation of where to put any extra details would help some common themes to emerge.
  • A meeting participant proposed to raise a new issue: ResolveError needs a standard message to be used on raiseIntent functions to indicate that the user closed the resolver.
    • participant or @kriswest to raise the issue.
  • A meeting participant proposed to raise a new issue: IntentHandler should know who raised an intent (for audit logging purposes) - perhaps an AppMetadata object passed to the handler function.
    • participant to raise the issue with a use-case.

Action Items

  • (no owner recorded) Raise new issue: ResolveError needs a standard message to be used on raiseIntent functions to indicate that the user closed the resolver.
  • (no owner recorded) Raise new issue: IntentHandler should know who raised an intent (for audit logging purposes)
  • @kriswest prepare summary of proposals for SWG meeting 16th Dec.
  • All participants to review the PRs!
  • @kriswest to email fdc3 list about whether to hold a further meeting and on what date.
  • Rolled over from previous meetings:

Untracked attendees

Full name Affiliation GitHub username
@kriswest kriswest added help wanted Extra attention is needed meeting channels feeds & transactions Channels, Feeds & Transactions Discussion Group labels Nov 30, 2021
@openfin-gavin
Copy link

Gavin Lauchlan // OpenFin

@hampshan
Copy link

Andrew Hampshire @ UBS

@thorsent
Copy link

Present

@symphony-adnane
Copy link

Adnane T @symphony

@donbasuno
Copy link
Contributor

Johan - FactSet 🎁

@pgn-vole
Copy link

Yacine Zalouani - UBS

@kriswest
Copy link
Contributor Author

Kris West / Cosaic

@ggeorgievx
Copy link
Member

Present ✅

@Julia-Ritter
Copy link
Contributor

Julia / FINOS

@pbaize
Copy link

pbaize commented Nov 30, 2021

Pierre / OpenFin

@kriswest kriswest closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channels feeds & transactions Channels, Feeds & Transactions Discussion Group help wanted Extra attention is needed meeting
Projects
None yet
Development

No branches or pull requests

10 participants