Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppD schema does a poor job of validating icons and screenshots #1036

Closed
kriswest opened this issue Jul 24, 2023 · 0 comments · Fixed by #1037
Closed

AppD schema does a poor job of validating icons and screenshots #1036

kriswest opened this issue Jul 24, 2023 · 0 comments · Fixed by #1037
Labels
app-directory bug Something isn't working
Milestone

Comments

@kriswest
Copy link
Contributor

Area of Issue

[x] App Directory

Issue Description:

Icons in app appD records should have a format like:

...,
"icons": [
    "src": "<some URL>,
    "size": "25x45",
    "type": "image/png"
],
...

(the last two fields are optional, the src field should be required)

However, the schema is poorly written in that it is missing the required property declaration and does not preclude additionalValues. Hence, an entry such as:

...,
"icons": [
    "url": "<some URL>,
],
...

will validate as src was not correctly required in the schema and additional properties are allowed.

Refine the schema so that it can better validate appD records.

@kriswest kriswest added bug Something isn't working app-directory labels Jul 24, 2023
@kriswest kriswest added this to the 2.1-candidates milestone Jul 24, 2023
@kriswest kriswest changed the title AppD schema does a poor job of validating icons, screenshots and other subschemas AppD schema does a poor job of validating icons and screenshots Jul 24, 2023
@kriswest kriswest modified the milestones: 2.1-candidates, 2.1 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant