Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataflow Bug #355

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Dataflow Bug #355

merged 7 commits into from
Dec 20, 2023

Conversation

nullplay
Copy link
Collaborator

Fix #339

  1. Fix applied in for of mark_dead. I'm not sure if this is correct (@willow-ahrens)
  2. Add test case in test_issues.jl

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here, you may need to regenerate test output to get the doctests to pass.

@willow-ahrens
Copy link
Collaborator

Very clever catch btw, and nice fix!

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88c0976) 75.06% compared to head (7e3dcfa) 75.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   75.06%   75.96%   +0.90%     
==========================================
  Files          78       78              
  Lines        6598     6600       +2     
==========================================
+ Hits         4953     5014      +61     
+ Misses       1645     1586      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willow-ahrens willow-ahrens merged commit df553b8 into main Dec 20, 2023
8 checks passed
@willow-ahrens willow-ahrens deleted the jaeyeon/fixdataflow branch January 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in dataflow analysis
2 participants