Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: No task icon #16320

Closed
IviriusMain opened this issue Oct 7, 2024 · 11 comments · Fixed by #16321
Closed

Bug: No task icon #16320

IviriusMain opened this issue Oct 7, 2024 · 11 comments · Fixed by #16321
Labels
needs - additional info Needs more information from the reporter needs - reproducing Issues unable to be reproduced by the dev team

Comments

@IviriusMain
Copy link
Contributor

Description

There's no icon for the Files task in Task Manager

Steps To Reproduce

  1. Open Files
  2. Open Task Manager
  3. No icon

Requirements

There should be the current icon of Files in Task Manager

Files Version

3.7.7.0

Windows Version

10.0.22631.4249

User ID

No response

Log File

debug.log
@IviriusMain
Copy link
Contributor Author

I have fixed this issue in a fork and I'm ready to make a pull request.

@IviriusMain IviriusMain mentioned this issue Oct 7, 2024
Merged
@yaira2
Copy link
Member

yaira2 commented Oct 7, 2024

I can't reproduce this issue in the latest preview build. Can you check if it's resolved on your end as well?
Image

@yaira2 yaira2 added needs - additional info Needs more information from the reporter needs - reproducing Issues unable to be reproduced by the dev team labels Oct 7, 2024
@IviriusMain
Copy link
Contributor Author

It's not resolved - above is the latest Insider build, and below is the updated version in this pull request.

Image

@IviriusMain
Copy link
Contributor Author

Image

(What they look like in the taskbar)

@IviriusMain
Copy link
Contributor Author

IviriusMain commented Oct 7, 2024 •
edited
Loading

Image

Expanded view for better reference (same thing: above is the latest Insider build, below is the build in this pull request)

@Josh65-2201
Copy link
Member

I can reproduce this on 3.7.7 and 3.7.10
Image

@yaira2
Copy link
Member

yaira2 commented Oct 8, 2024 •
edited
Loading

We're using the WinUIEx SetAppIcon method. Is this a known issue?

@0x5bfa
Copy link
Member

0x5bfa commented Oct 8, 2024 •
edited
Loading

I think that is for window icon. We haven't added an exe/process icon and as a result sometimes it causes the issue. And what is shown on Taskbar is probably comes from the appxmanifest

@IviriusMain
Copy link
Contributor Author

Pretty much, yeah.

@yaira2
Copy link
Member

yaira2 commented Oct 9, 2024

This will be included in the next update.

@0x5bfa
Copy link
Member

0x5bfa commented Oct 9, 2024

Resolved by #16321

@0x5bfa 0x5bfa closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs - additional info Needs more information from the reporter needs - reproducing Issues unable to be reproduced by the dev team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Added Files icon to the process in Windows IviriusMain/Files
4 participants
@Josh65-2201 @yaira2 @0x5bfa @IviriusMain