Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging and error handling audit #272

Merged
merged 12 commits into from
Oct 17, 2022
Merged

Logging and error handling audit #272

merged 12 commits into from
Oct 17, 2022

Conversation

dnkolegov
Copy link
Contributor

No description provided.

@dnkolegov dnkolegov changed the title Draft: add default logger Draft: Logging and error handling ausit Oct 13, 2022
@dnkolegov dnkolegov changed the title Draft: Logging and error handling ausit Draft: Logging and error handling audit Oct 13, 2022
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnkolegov dnkolegov changed the title Draft: Logging and error handling audit Logging and error handling audit Oct 14, 2022
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Just minor comments.

pkg/net/grpc/grpctransport.go Show resolved Hide resolved
pkg/simplewal/simplewal.go Outdated Show resolved Hide resolved
pkg/systems/smr/appmodule.go Outdated Show resolved Hide resolved
pkg/iss/pbftviewchange.go Outdated Show resolved Hide resolved
pkg/iss/pbftviewchange.go Outdated Show resolved Hide resolved
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants