Simple mempool module prototype #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matejpavlovic for integrating mempool into the chat demo, modifications need to be made to ISS. I think I'm not the right person to do these modifications as I don't know anything about the ISS implementation. |
xosmig
force-pushed
the
mempool-prototype
branch
3 times, most recently
from
c4c380f
to
7377f27
Compare
pkg/mempool/simplemempool/internal/parts/formbatches/formbatches.go
Outdated
Show resolved
Hide resolved
|
depends on #164 |
xosmig
force-pushed
the
mempool-prototype
branch
2 times, most recently
from
76c7949
to
88166b4
Compare
xosmig
force-pushed
the
mempool-prototype
branch
3 times, most recently
from
e0af2d5
to
f15c806
Compare
The prototype expects that new transactions will be delivered to it by means of NewRequests events and stores them in an in-memory map. It uses hashes for transaction and batch IDs. To support crash-recovery, persistent storage should be added for the transactions.
|
I have no idea why the linter in the CI fails. It works locally on my laptop. |
|
The linter complains about files that were not changed in this PR, so I will just ignore it.
|
matejpavlovic
approved these changes
Aug 5, 2022
|
Actually, the comments can easily be fixed. Sergey had the same problem and this is the fix: 888d9cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prototype expects that new transactions will be delivered to it by means of
NewRequestsevents and stores them in an in-memory map. It uses hashes for transaction and batch IDs.To support crash-recovery, persistent storage should be added for the transactions.