Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libp2p #126

Merged
merged 22 commits into from
Jul 12, 2022
Merged

Add libp2p #126

merged 22 commits into from
Jul 12, 2022

Conversation

dnkolegov
Copy link
Contributor

This PR adds support for libp2p transport.

@matejpavlovic matejpavlovic mentioned this pull request Jul 11, 2022
Closed
adlrocha
adlrocha approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, @dnkolegov. Looks good for a first iteration.

matejpavlovic
matejpavlovic reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments / questions. Didn't dive too deeply into the technicalities of libp2p, trust you on that ;)

cmd/mircat/debug.go Outdated Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Outdated Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Outdated Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Outdated Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Outdated Show resolved Hide resolved
pkg/net/libp2p/libp2ptransport.go Show resolved Hide resolved
@matejpavlovic
Copy link
Contributor

Oh and one more important thing: don't forget to squash the commits before merging :-D

matejpavlovic
matejpavlovic approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/net/libp2p/libp2ptransport.go Show resolved Hide resolved
@dnkolegov dnkolegov merged commit 692c54a into main Jul 12, 2022
@dnkolegov dnkolegov deleted the libp2p branch July 12, 2022 20:15
@dnkolegov dnkolegov mentioned this pull request Jul 12, 2022
Closed
@adlrocha adlrocha mentioned this pull request Jul 19, 2022
Closed
@matejpavlovic matejpavlovic mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlrocha adlrocha adlrocha approved these changes

@matejpavlovic matejpavlovic matejpavlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnkolegov @matejpavlovic @adlrocha