Add ContextStore as a way to simplify context recovery #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
approved these changes
Jun 20, 2022
xosmig
force-pushed
the
contextstore
branch
5 times, most recently
from
7f0025f
to
2a7a7f5
Compare
The goal of contextstore is to simplify context recovery when working with modules like Crypto and Hasher. Currently, using these modules requires creating a new protobuf type each time the user wants to verify a signature or compute a hash. This is associated with a lot of boilerplate code. ContextStore allows saving the context locally in the module and only sending an automatically generated id in a standard ContextStoreOrigin protobuf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, working with signatures and hashes in mir is associated with a lot of boilerplate due to the need to create new protobuf types and wrap / unwrap them. The idea of
ContextStoreis to create a more general way to recover the context after the control flow returns to the module.I want
ContextStoreto be used by default in dsl modules (see #102), with some nice wrappers so that the user doesn't have to think about it.Open questions: