Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieval deals shouldn't be queued concurrently when CID/miner match #5443

Closed
dineshshenoy opened this issue Jan 27, 2021 · 0 comments · Fixed by #5853
Closed

Retrieval deals shouldn't be queued concurrently when CID/miner match #5443

dineshshenoy opened this issue Jan 27, 2021 · 0 comments · Fixed by #5853
Assignees
Labels
area/markets/client area/markets/retrieval team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs

Comments

@dineshshenoy
Copy link

When a transfer is interrupted or it's not clear that a deal is in-progress, it's common for a human or code to retry. If there is an existing retrieval deal with the same CID/client-id on the miner that is already in the queue, we should just return that deal-ID rather than creating a new deal.

There is an edge case that the price of the retrieval deal could get cheaper, but the request is that price is ignored. The previous deal can be canceled if they want to resubmit the request and go to the end of the queue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/markets/client area/markets/retrieval team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants