Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Transfer: Cleanup graphsync requests that time out in the FSM #3878

Closed
aarshkshah1992 opened this issue Sep 16, 2020 · 2 comments
Closed

Data Transfer: Cleanup graphsync requests that time out in the FSM #3878

aarshkshah1992 opened this issue Sep 16, 2020 · 2 comments
Assignees
@aarshkshah1992
Labels
area/markets Area: Markets dif/medium Prior development experience with lotus is likely helpful effort/hours Effort: Hours kind/enhancement Kind: Enhancement P1 P1: Must be resolved

Comments

@aarshkshah1992
Copy link
Contributor

Once filecoin-project/go-data-transfer#78 goes in, we will receive callbacks in go-data-transfer when graphsync requests we have opened to receive data time out.

We should remove these timed out requests/channels from the channel state machine to reclaim the go-routines we have running for them as these requests will NOT terminate.

cc @hannahhoward
@aarshkshah1992 aarshkshah1992 self-assigned this Sep 16, 2020
@aarshkshah1992 aarshkshah1992 changed the title Data Transfer: Cleanup requests that time out in the FSM Data Transfer: Cleanup graphsync requests that time out in the FSM Sep 16, 2020
@aarshkshah1992 aarshkshah1992 added the area/markets Area: Markets label Sep 16, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue Sep 16, 2020
Merged
@aarshkshah1992
Copy link
Contributor Author

@hannahhoward 's comment here:

filecoin-project/go-data-transfer#78 (comment)

should also be incorporated into this work.

@hannahhoward hannahhoward added dif/medium Prior development experience with lotus is likely helpful effort/hours Effort: Hours kind/enhancement Kind: Enhancement P1 P1: Must be resolved labels Sep 17, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue Sep 30, 2020
Merged
@rjan90
Copy link
Contributor

rjan90 commented Mar 27, 2022

Hey! 😄 It seems like this issue has been fixed & merged. So closing this now.

@rjan90 rjan90 closed this as completed Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarshkshah1992 aarshkshah1992

Labels
area/markets Area: Markets dif/medium Prior development experience with lotus is likely helpful effort/hours Effort: Hours kind/enhancement Kind: Enhancement P1 P1: Must be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hannahhoward @aarshkshah1992 @rjan90