Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.19 #10578

Closed
6 of 11 tasks
LexLuthr opened this issue Mar 28, 2023 · 2 comments · Fixed by #10581
Closed
6 of 11 tasks

Update go version to 1.19 #10578

LexLuthr opened this issue Mar 28, 2023 · 2 comments · Fixed by #10581
Labels
kind/bug Kind: Bug

Comments

@LexLuthr
Copy link
Contributor

LexLuthr commented Mar 28, 2023

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

v1.21.0-rc1

Repro Steps

Try to build the docker image of lotus.

docker build --build-arg LOTUS_TEST_IMAGE=filecoin/lotus-all-in-one:v1.21.0-rc1-debug --build-arg FFI_BUILD_FROM_SOURCE=0  -f Dockerfile --target lotus-all-in-one \
	-t filecoin/lotus-all-in-one:v1.21.0-rc1-debug --build-arg GOFLAGS=-tags=debug .

Describe the Bug

When I try to build a lotus docker image, it fails with below error:

Step 12/79 : RUN make clean deps
 ---> Running in df52d903b86e
Makefile:14: Your Golang version is go1.18.8
Makefile:15: *** Update Golang to version to at least 1.19.7.  Stop.
The command '/bin/sh -c make clean deps' returned a non-zero code: 2
make: *** [Makefile:232: docker/lotus-all-in-one] Error 2

I think requirement is coming from one of the dependencies and as long as user builds Lotus manually outside docker, it will work if they are using go v1.19.x
But, docker is strict in the sense it will use defined image of v1.18.x in the Dockerfile.

Logging Information

Not required
@LexLuthr
Copy link
Contributor Author

@rjan90 Hey, I am not able to build Lotus with go 1.18 even outside the container. I think we should update the go.mod file to 1.19 for v.1.21-0-rc1

root@c9ea3db2f2aa:/lotus# make clean all
Makefile:14: Your Golang version is go1.18.8
Makefile:15: *** Update Golang to version to at least 1.19.7.  Stop.
root@c9ea3db2f2aa:/lotus# go version
go version go1.18.8 linux/amd64

@rjan90
Copy link
Contributor

rjan90 commented Mar 29, 2023

Hey @LexLuthr I updated go.mod here, so now it should be updated for the v1.21.0-rc2: https://github.com/filecoin-project/lotus/pull/10594/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants