Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CLI flags and Lassie initialization logic #257

Closed
kylehuntsman opened this issue May 26, 2023 · 1 comment · Fixed by #289
Closed

Unify CLI flags and Lassie initialization logic #257

kylehuntsman opened this issue May 26, 2023 · 1 comment · Fixed by #289
Assignees
Labels
tech debt Non-critical change that can wait to be addressed

Comments

@kylehuntsman
Copy link
Contributor

Both the daemon and fetch CLI commands have similar flags and use similar Lassie initialization logic. We should dedupe these flags and logic to ensure a consistent experience across both uses of the application.

@kylehuntsman kylehuntsman added the tech debt Non-critical change that can wait to be addressed label May 26, 2023
@hannahhoward
Copy link
Collaborator

hannahhoward commented May 27, 2023

we have done a decent, if not uniform, job of moving flags that are shared to flags.go in the cmd/lassie directory. However the code to read these flags -- the same ones -- are duplicated across both commands, as is the code to construct lassie from those flags. I'd envision a function in cmd/lassie like BuildLassieFromCLIContext(cctx *cli.Context) *lassie.Lassie that reads the shared flags and makes Lassie from it.

Also, it may make sense to implement this ticket along with #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Non-critical change that can wait to be addressed
Projects
None yet
2 participants