Add funds to payment channel before allocating lane #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Feb 24, 2021
| From(rm.DealStatusPaymentChannelCreating).To(rm.DealStatusPaymentChannelAllocatingLane). | ||
| From(rm.DealStatusPaymentChannelAddingInitialFunds).To(rm.DealStatusPaymentChannelAllocatingLane). |
There was a problem hiding this comment.
I am a bit confused with naming here. Why Initial funds? If the payment channel existed and ran out of funds, wouldn't it be better to call it AddingMoreFunds?
There was a problem hiding this comment.
I guess it is Initial, because this is adding funds for a new deal, right?
There was a problem hiding this comment.
Right exactly, the funds are for the new deal 👍
nonsense
approved these changes
Feb 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before retrieving a file, the client must create a payment channel to pay for retrieval. Each deal has a separate lane in the payment channel that is used to manage funds for that particular deal.
The steps are:
If a payment channel already exists in step 1, funds must be added to the existing channel. This PR fixes a bug where the retrieval market state machine would not wait for the add funds message to land on chain before continuing, which caused issues when creating vouchers against the payment channel.