New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create integration tests for retrieval with > 0 unseal price #527

Closed

dirkmc opened this issue Mar 31, 2021 · 0 comments · Fixed by #525

Assignees

Labels

x/ignite

Contributor

dirkmc commented Mar 31, 2021 •

edited

Loading

Currently there is only one integration test for retrieval, and it only tests the case where price-per-byte > 0 and unseal price is 0.

We should create tests for retrieval for the following scenarios:

Unseal price zero, Price per byte zero
Unseal price zero, Price per byte positive
Unseal price positive, Price per byte zero
Unseal price positive, Price per byte positive

This will help us track down the root cause of filecoin-project/lotus#5829

dirkmc assigned aarshkshah1992

dirkmc added the x/ignite label

dirkmc mentioned this issue

Restart resilience for retrievals filecoin-project/lotus#5914

Closed

8 tasks

aarshkshah1992 mentioned this issue

Flush out & fix retrieval bugs #525

Merged

2 tasks

dirkmc closed this as completed in #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment