Retrieval client fails to resume after opening payment channel

[dirkmc]

Background

When making a retrieval, the process is:

1. Client opens data transfer channel
2. Provider accepts
3. Client opens payment channel
4. Client sends funds
5. Provider sends data

With the current markets release there is a bug where the client does not send funds in step 4. Instead, the retrieval gets stuck:

ClientEventOpen
ClientEventDealProposed
ClientEventDealAccepted
ClientEventPaymentChannelAddingFunds
ClientEventPaymentChannelReady
ClientEventLaneAllocated
  <no further events>

The provider does send a request for payment while the client is in the state DealStatusPaymentChannelAddingInitialFunds.
However the client ignores the event.

It seems the reason is because DealStatusPaymentChannelAddingInitialFunds is not included in the list of payment channel creation states:

go-fil-markets/retrievalmarket/impl/clientstates/client_fsm.go

Lines 23 to 29 in 7ff7573

	var paymentChannelCreationStates = []fsm.StateKey{
	rm.DealStatusWaitForAcceptance,
	rm.DealStatusWaitForAcceptanceLegacy,
	rm.DealStatusAccepted,
	rm.DealStatusPaymentChannelCreating,
	rm.DealStatusPaymentChannelAllocatingLane,
	}

So when the provider requests payment, and the ClientEventPaymentRequested event is fired, the event is ignored:

go-fil-markets/retrievalmarket/impl/clientstates/client_fsm.go

Lines 177 to 187 in 7f8d9b6

	fsm.Event(rm.ClientEventPaymentRequested).
	FromMany(
	rm.DealStatusOngoing,
	rm.DealStatusBlocksComplete,
	rm.DealStatusFundsNeeded).To(rm.DealStatusFundsNeeded).
	FromMany(
	paymentChannelCreationStates...).ToJustRecord().
	Action(func(deal *rm.ClientDealState, paymentOwed abi.TokenAmount) error {
	deal.PaymentRequested = big.Add(deal.PaymentRequested, paymentOwed)
	return nil
	}),

Solution

We just need to add DealStatusPaymentChannelAddingInitialFunds to paymentChannelCreationStates