Dont double-count queued / sent / received data when channel restarted #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
test/restart-block-resend
branch
4 times, most recently
from
a977980
to
68d37f4
Compare
dirkmc
force-pushed
the
test/restart-block-resend
branch
from
68d37f4
to
7607b16
Compare
dirkmc
force-pushed
the
test/restart-block-resend
branch
from
9883af0
to
81ab709
Compare
dirkmc
changed the title
dirkmc
changed the title
hannahhoward
approved these changes
Jan 29, 2021
| // When a data transfer is restarted, the requester sends a list of CIDs | ||
| // that it already has. Graphsync calls the sent hook for all blocks even | ||
| // if they are in the list (meaning, they aren't actually sent over the | ||
| // wire). So here we check if the block was actually sent |
There was a problem hiding this comment.
Given your CIDsets functionality this check is probably not necessary, FWIW.
There was a problem hiding this comment.
It may make for greater optimization though.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data transfer module subscribes to hooks called by graphsync when a block is queued or sent.
When a data transfer is restarted, Graphsync calls these hooks again with all the blocks that have already been queued and sent, with a BlockSizeOnWire() of zero.
This PR modifies event handling such that
DataSentandDataQueuedare only fired ifblock.BlockSizeOnWire()is non-zeroDataQueuedProgress,DataSentProgressandDataReceivedProgressare fired only the first time a block is queued / sent / receivedIn order to keep track of which blocks have been queued / sent / received, a new class has been added:
CIDSetManager.Each channel has a cid set for queued / sent / received.