Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-712 Replay Protection #90

Open
xBalbinus opened this issue Dec 16, 2024 · 2 comments
Open

EIP-712 Replay Protection #90

xBalbinus opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
from slack Painpoint request flagged from Slack

Comments

@xBalbinus
Copy link
Collaborator

Description:
FYI - filecoin-project/lotus#12761
When you’re signing a raw message, the EIP-191 Signed Data Standard adds a prefix so that the message can never be a scam transaction. Hugo is requesting adoption of this common Ethereum standard in Filecoin by Lotus, FEVM contexts, L2s, etc. which is why he’s tagged the folks in this Lotus issue.

cc: @jiayingw703 @orjan.roren @sarahthiamjiahui

Fil-b Team: Related is also EIP-712 which is popular in the Eth community, explained well in https://www.cyfrin.io/blog/understanding-ethereum-signature-standards-eip-191-eip-712this article> and adds replay protection and would get us to clear signing on Ledger. It’s also supported by a lot of wallets and Hugo could add support for it to the iso-filecoin JS library.

Source:
https://filecoinproject.slack.com/archives/C0745JU645A/p1733408325343369?thread_ts=1733408325.343369&cid=C0745JU645A

@xBalbinus xBalbinus added the from slack Painpoint request flagged from Slack label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to 🌑 Unstarted / Needs Triage in Filecoin DX Painpoints Tracker Dec 16, 2024
@xBalbinus xBalbinus changed the title <New Issue From Slack> EIP-712 Replay Protection Jan 7, 2025
@xBalbinus
Copy link
Collaborator Author

cc @snissn // @trruckerfling for triage. You guys know the FEVM compatibility scene better than I do.

@trruckerfling
Copy link
Collaborator

requires more info from Hugo

@trruckerfling trruckerfling moved this from 🌑 Unstarted / Needs Triage to 🎒Backlog in Filecoin DX Painpoints Tracker Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from slack Painpoint request flagged from Slack
Projects
Status: 🎒Backlog
Development

No branches or pull requests

4 participants
@snissn @xBalbinus @trruckerfling and others