Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recaptcha race condition #1176

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

WeidiDeng
Copy link
Contributor

Description
Currently when using recaptcha, there's a chance when vue mounted was called, render was not ready. Can be reproduced on macos big sur 11.01 and ipad OS 14.2 safari browser.

Using ready function to render the recaptcha. Fixes 1167;

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

❤️ Thank you!

@o1egl o1egl merged commit ac3673e into filebrowser:master Dec 8, 2020
@o1egl
Copy link
Member

o1egl commented Dec 8, 2020

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Racing condition when using grecaptcha
2 participants