Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG:ui.js entity.addEditor is not a function #716

Closed
youngjuning opened this issue Mar 14, 2018 · 7 comments
Closed

BUG:ui.js entity.addEditor is not a function #716

youngjuning opened this issue Mar 14, 2018 · 7 comments
Labels
unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation.

Comments

@youngjuning
Copy link

Uncaught (in promise) TypeError: entity.addEditor is not a function
at disposables.add.onOpenFile.editor

@ericcornelissen
Copy link
Contributor

I'm having the same issue, here is how you may be able to reproduce it (I'm on Windows 10):

  1. Clone this repository
  2. Open the repository in Atom
  3. Open the file site/build/build.sh

@Alhadis
Copy link
Member

Alhadis commented Mar 14, 2018

Guys, when you see errors like this, please include the stack-trace. That's the single most important part of a bug report, because it pinpoints where things are going wrong and how they can be fixed.

I'm away-from-Atom at the moment, but I'll try looking into this soon.

Please also tell me what version of Atom you're running.

@ericcornelissen
Copy link
Contributor

I'm running Atom 1.24.1 and here is my stacktrace:

Uncaught (in promise) TypeError: entity.addEditor is not a function
    at disposables.add.onOpenFile.editor (C:\Users\erico\.atom\packages\file-icons\lib\ui.js:40:12)
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at disposables.add.atom.workspace.observeTextEditors.editor (C:\Users\erico\.atom\packages\file-icons\lib\ui.js:68:19)
    at C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\workspace.js:732:22
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\workspace.js:586:34
    at C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\workspace.js:587:19
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at PaneContainer.didAddPaneItem (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\pane-container.js:270:24)
    at Pane.addItem (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\pane.js:632:48)
    at Pane.activateItem (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\pane.js:574:18)
    at Workspace.<anonymous> (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\workspace.js:1178:20)
    at Generator.next (<anonymous>)
    at step (C:\Users\erico\AppData\Local\atom\app-1.24.1\resources\app\src\workspace.js:11:279)

@youngjuning
Copy link
Author

youngjuning commented Mar 15, 2018

My Atom version is 1.25.0 beta3

@deekay44
Copy link

deekay44 commented Apr 6, 2018

Same problem. Atom v1.25.1. But on my laptop with the same OS (Windows 10) and the same Atom version and packages I havn't this problem, and this was strange.

Uncaught (in promise) TypeError: entity.addEditor is not a function
    at disposables.add.onOpenFile.editor (C:\Users\Dmitry\.atom\packages\file-icons\lib\ui.js:40:22)
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at disposables.add.atom.workspace.observeTextEditors.editor (C:\Users\Dmitry\.atom\packages\file-icons\lib\ui.js:68:19)
    at onDidAddTextEditor (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\workspace.js:638:60)
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at onDidAddPaneItem (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\workspace.js:519:28)
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\node_modules\event-kit\lib\emitter.js:141:34)
    at PaneContainer.didAddPaneItem (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\pane-container.js:271:24)
    at Pane.addItem (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\pane.js:632:48)
    at Pane.activateItem (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\pane.js:574:18)
    at Workspace.open (C:\Users\Dmitry\AppData\Local\atom\app-1.25.1\resources\app\src\workspace.js:1042:18)
    at <anonymous>

@Alhadis
Copy link
Member

Alhadis commented Apr 6, 2018

Can you reproduce this error consistently, or is just a one-off occurrence?

If it's the former, can you tell me how many tabs you had open, and what editor commands you're running to invoke the error?

@deekay44
Copy link

deekay44 commented Apr 7, 2018

Yes, same situation happened on my laptop, same packages and Atom version.

how many tabs you had open

~5-10, but this was occurs if open tabs one by one too, i mean opening one tab then close and opening another one.

and what editor commands you're running to invoke the error?

Simple file opening. I want to note that file not opening after first double-click, only after second one, but I think it happens because error in console. For better understanding added screenshot.

atom

P.S. Sry for bad English.

@Alhadis Alhadis added the unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation. label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unconfirmed-bug Unreproducible error observed by user, or an unclear bug requiring further investigation.
Projects
None yet
Development

No branches or pull requests

4 participants