Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Icons aligned to top when using Remote-Edit #271

Closed
arda- opened this issue Feb 3, 2016 · 4 comments
Closed

File Icons aligned to top when using Remote-Edit #271

arda- opened this issue Feb 3, 2016 · 4 comments
Assignees
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. styling Questions and bugs related to package and user stylesheets.

Comments

@arda-
Copy link

arda- commented Feb 3, 2016

When using the package remote edit, the icons seem to be aligned to the top of the tab instead of the window. This occurs with many different file types.

Here are a variety of remotely opened files:
screen shot 2016-02-03 at 11 00 00 am

Here is a remotely opened file next to a local one:
screen shot 2016-02-03 at 11 05 29 am

Not quite sure whether this is an issue more appropriate for your project, or the other! I posted to both, just in case.

@Alhadis
Copy link
Member

Alhadis commented Feb 24, 2016

@arda- Can you pop the inspector tools open and examine the CSS class of the misaligned icon? (View → Developer → Toggle Developer Tools). How does it differ from the properly-aligned icon?

I currently don't have access to a remote server where I can reproduce this.

@sdbarron
Copy link

A local file tab has only a class of "title" while a remote-edit tab has "title icon icon-globe". It seems as if remote-edit is trying to do icon functionality (which sounds good) but it's incompatible with at least this other icon package.

@Alhadis
Copy link
Member

Alhadis commented Mar 25, 2016

Right, found it. These lines are the culprit:

Patching it right now. We don't have a class named icon-globe (at least not yet), so we can safely target it in the tab-pane and reset those damn properties.

@Alhadis Alhadis self-assigned this Mar 25, 2016
@Alhadis
Copy link
Member

Alhadis commented Mar 25, 2016

Alright, done. Sorry about the delay, I was adding a new icon. :) Figure I may as well push both out with the one release.

@Alhadis Alhadis added bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. styling Questions and bugs related to package and user stylesheets. labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. styling Questions and bugs related to package and user stylesheets.
Projects
None yet
Development

No branches or pull requests

3 participants