Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libusb panic with multiple close calls on linux #140

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

libusb panic with multiple close calls on linux #140

isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Describe the bug
The usb library panics when the Close function is called multiple times on the same connection

Steps to Reproduce
Steps to reproduce the behavior:

  1. Replace this with https://github.com/skycoin/hardware-wallet-go/blob/55c993a8e132901cff67d3acbb6be3266fdb1ff1/src/skywallet/skywallet.go#L656-L668
// GetFeatures send Features message to the device
func (d *Device) GetFeatures() (wire.Message, error) {
	if err := d.Connect(); err != nil {
		return wire.Message{}, err
	}
	d.dev.Close(false)
	d.dev.Close(false)
	
	return wire.Message{}, nil
}
  1. Then execute this command
$ go run cmd/cli/cli.go features

Actual behavior
panic in usblib

Expected behavior
no panic in usblib

@isaacvr isaacvr added the bug Something isn't working label Oct 31, 2019
@isaacvr isaacvr added this to the next milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant